Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966382AbbD2Q7n (ORCPT ); Wed, 29 Apr 2015 12:59:43 -0400 Received: from www62.your-server.de ([213.133.104.62]:36308 "EHLO www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753776AbbD2Q7l (ORCPT ); Wed, 29 Apr 2015 12:59:41 -0400 Message-ID: <55410DF6.3090901@iogearbox.net> Date: Wed, 29 Apr 2015 18:59:34 +0200 From: Daniel Borkmann User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Pranith Kumar , mancha security CC: "H. Peter Anvin" , LKML , Ingo Molnar Subject: Re: [PATCH] compiler-intel: fix wrong compiler barrier() macro References: <20150429145956.GB12861@zoho.com> In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated-Sender: daniel@iogearbox.net Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 984 Lines: 19 On 04/29/2015 06:40 PM, Pranith Kumar wrote: > On Wed, Apr 29, 2015 at 10:59 AM, mancha security wrote: >> >> The problem is that ICC defines __GNUC__ so barrier() gets defined >> in compiler-gcc.h. Your commit removed an #undef from compiler-intel.h >> so compiler.h will never define barrier to __memory_barrier(). > > OK, I see your point. But, ICC has support for GCC inline assembly. So > the change does not seem to be making any difference. We are using our > own asm barrier rather than the inbuilt one provided by ICC. It does make a difference: gcc inline assembly is not supported by /ecc/, see that it's wrapped within the ifdef __ECC part. I believe, that should be for ia64 which we have under arch/, no? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/