Date: Wed, 29 Apr 2015 13:08:52 -0400
From: Steven Rostedt <rostedt@goodmis.org>
To: Shreyas B Prabhu <shreyas@linux.vnet.ibm.com>
Cc: Preeti Murthy <preeti.lkml@gmail.com>,
        Paul McKenney <paulmck@linux.vnet.ibm.com>,
        LKML <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@redhat.com>,
        aneesh.kumar@linux.vnet.ibm.com,
        Preeti U Murthy <preeti@linux.vnet.ibm.com>
Subject: Re: [PATCH 3/3] tracing/mm: Don't trace mm_page_pcpu_drain on
 offline cpus
Message-ID: <20150429130852.487100d9@gandalf.local.home>
In-Reply-To: <5540FFAE.2050502@linux.vnet.ibm.com>
References: <1430236283-29360-1-git-send-email-shreyas@linux.vnet.ibm.com>
	<1430236283-29360-3-git-send-email-shreyas@linux.vnet.ibm.com>
	<CAM4v1pM8aSExCcmUG3dP7bPAGFpwHYZf-ncMueMtguDXc8fjNw@mail.gmail.com>
	<5540EF78.8000409@linux.vnet.ibm.com>
	<20150429111812.60b697c6@gandalf.local.home>
	<5540FFAE.2050502@linux.vnet.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1245
Lines: 33

On Wed, 29 Apr 2015 21:28:38 +0530
Shreyas B Prabhu <shreyas@linux.vnet.ibm.com> wrote:

> 
> 
> On Wednesday 29 April 2015 08:48 PM, Steven Rostedt wrote:
> > On Wed, 29 Apr 2015 20:19:28 +0530
> > Shreyas B Prabhu <shreyas@linux.vnet.ibm.com> wrote:
> > 
> >> IIUC there is no existing macro which can both add a condition and
> >> override printk format, hence the fall back to TRACE_EVENT_CONDITION.
> > 
> > Hmm, want me to send you a patch that changes that?
> > 
> I am not sure if its worth the effort now. It doesn't look like any
> other trace point apart from the above use case will benefit from it.
> Only smbus_write and smbus_reply seem to come close. But even they need
> separate TP_fast_assign.

It shouldn't be a problem to implement. But I'm currently cleaning up
those files, and any changes will cause nasty conflicts.

Lets do this. Push the current changes as is, and when I get around to
adding a DEFINE_EVENT_PRINT_CONDITION(), we can modify that code to use
it.

-- Steve

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/