Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966374AbbD2RSc (ORCPT ); Wed, 29 Apr 2015 13:18:32 -0400 Received: from mail-ob0-f172.google.com ([209.85.214.172]:36699 "EHLO mail-ob0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966050AbbD2RS2 (ORCPT ); Wed, 29 Apr 2015 13:18:28 -0400 MIME-Version: 1.0 In-Reply-To: <55410DF6.3090901@iogearbox.net> References: <20150429145956.GB12861@zoho.com> <55410DF6.3090901@iogearbox.net> From: Pranith Kumar Date: Wed, 29 Apr 2015 13:17:57 -0400 Message-ID: Subject: Re: [PATCH] compiler-intel: fix wrong compiler barrier() macro To: Daniel Borkmann Cc: mancha security , "H. Peter Anvin" , LKML , Ingo Molnar Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1301 Lines: 33 On Wed, Apr 29, 2015 at 12:59 PM, Daniel Borkmann wrote: > On 04/29/2015 06:40 PM, Pranith Kumar wrote: >> >> On Wed, Apr 29, 2015 at 10:59 AM, mancha security >> wrote: >>> >>> >>> The problem is that ICC defines __GNUC__ so barrier() gets defined >>> in compiler-gcc.h. Your commit removed an #undef from compiler-intel.h >>> so compiler.h will never define barrier to __memory_barrier(). >> >> >> OK, I see your point. But, ICC has support for GCC inline assembly. So >> the change does not seem to be making any difference. We are using our >> own asm barrier rather than the inbuilt one provided by ICC. > > > It does make a difference: gcc inline assembly is not supported by > /ecc/, see that it's wrapped within the ifdef __ECC part. I believe, > that should be for ia64 which we have under arch/, no? Yes, looks like this breaks building the kernel with ecc compiler on IA64. Has anyone tried building it with ECC on ia64 lately(or ever)? Reviewed-by: Pranith Kumar -- Pranith -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/