Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966430AbbD2Rbv (ORCPT ); Wed, 29 Apr 2015 13:31:51 -0400 Received: from mail-pd0-f174.google.com ([209.85.192.174]:36404 "EHLO mail-pd0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966307AbbD2Rbq (ORCPT ); Wed, 29 Apr 2015 13:31:46 -0400 From: Kevin Hilman To: Krzysztof Kozlowski Cc: Jingoo Han , Inki Dae , Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , David Airlie , Kukjin Kim , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org, Marek Szyprowski , Andrzej Hajda , Javier Martinez Canillas , stable@vger.kernel.org, Olof Johansson Subject: Re: [RFT PATCH] drm/exynos: Enable DP clock to fix display on Exynos5250 and other References: <1427471856-20918-1-git-send-email-k.kozlowski@samsung.com> Date: Wed, 29 Apr 2015 10:31:41 -0700 In-Reply-To: <1427471856-20918-1-git-send-email-k.kozlowski@samsung.com> (Krzysztof Kozlowski's message of "Fri, 27 Mar 2015 16:57:36 +0100") Message-ID: <7h8udau9he.fsf@deeprootsystems.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1622 Lines: 41 Krzysztof Kozlowski writes: > After adding display power domain for Exynos5250 in commit > 2d2c9a8d0a4f ("ARM: dts: add display power domain for exynos5250") the > display on Chromebook Snow and others stopped working after boot. > > The reason for this suggested Andrzej Hajda: the DP clock was disabled. > This clock is required by Display Port and is enabled by bootloader. > However when FIMD driver probing was deferred, the display power domain > was turned off. This effectively reset the value of DP clock enable > register. > > When exynos-dp is later probed, the clock is not enabled and display is > not properly configured: > > exynos-dp 145b0000.dp-controller: Timeout of video streamclk ok > exynos-dp 145b0000.dp-controller: unable to config video > > Signed-off-by: Krzysztof Kozlowski > Reported-by: Javier Martinez Canillas > Fixes: 2d2c9a8d0a4f ("ARM: dts: add display power domain for exynos5250") > Cc: > > --- > > This should fix issue reported by Javier [1][2]. > > Tested on Chromebook Snow (Exynos 5250). More testing would be great, > especially on other Exynos 5xxx products. I hoped to try this on my exynos5 boards, but it doesn't seem to apply to linux-next or to Linus' master branch. Are there some other dependencies here? Kevin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/