Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S933304AbbD2R5Z (ORCPT <rfc822;w@1wt.eu>);
	Wed, 29 Apr 2015 13:57:25 -0400
Received: from mx1.redhat.com ([209.132.183.28]:45874 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753704AbbD2R5Y (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 29 Apr 2015 13:57:24 -0400
Date: Wed, 29 Apr 2015 19:57:06 +0200
From: Jiri Olsa <jolsa@redhat.com>
To: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>, Ingo Molnar <mingo@kernel.org>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] perf tools: Fix bison-related build failure on CentOS 6
Message-ID: <20150429175705.GB8427@krava.redhat.com>
References: <1430322871-18107-1-git-send-email-namhyung@kernel.org>
 <20150429162740.GL2079@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150429162740.GL2079@redhat.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1426
Lines: 36

On Wed, Apr 29, 2015 at 01:27:40PM -0300, Arnaldo Carvalho de Melo wrote:
> > The YYLTYPE_IS_TRIVIAL is defined in the Build file, but unlike
> > pmu-bison.c, gcc complained about it for parse-events-bison.c:
> > 
> >     CC       util/parse-events-bison.o
> >   In file included from util/parse-events.y:16:
> >   util/parse-events-bison.h:101:1: error: "YYLTYPE_IS_TRIVIAL" redefined
> >   <command-line>: error: this is the location of the previous definition
> >   make[3]: *** [util/parse-events-bison.o] Error 1
> > 
> > Signed-off-by: Namhyung Kim <namhyung@kernel.org>
> 
> Ok, so this helps, it builds now on RHEL6.6, which was something I and
> Jiri were chasing, but why has it complained for one and not the other?
> Ideas?

looks like the RHEL6 gcc/cpp treats this as an error which
is not maskable by '-w' option

anyway I checked the git log history and I'm not sure
why we event have this define, it was added by Ingo
and carried by ever since:

  65f3e56e0c81 perf tools: Remove auto-generated bison/flex files

probably because of the fail I see if I remove it from pmu-bison.o build:

  util/pmu-bison.c:613:6: error: "YYLTYPE_IS_TRIVIAL" is not defined


jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/