Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966411AbbD2SMg (ORCPT ); Wed, 29 Apr 2015 14:12:36 -0400 Received: from mail-oi0-f54.google.com ([209.85.218.54]:35310 "EHLO mail-oi0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753824AbbD2SMd (ORCPT ); Wed, 29 Apr 2015 14:12:33 -0400 MIME-Version: 1.0 In-Reply-To: <20150429151527.GA8781@leverpostej> References: <1430146811-29862-1-git-send-email-geert+renesas@glider.be> <20150427155427.GB16191@leverpostej> <20150427171502.GD16191@leverpostej> <20150429125703.GB11757@leverpostej> <20150429151527.GA8781@leverpostej> Date: Wed, 29 Apr 2015 20:12:32 +0200 X-Google-Sender-Auth: M__d70Z2F4x_5q4XActU8I1iDeg Message-ID: Subject: Re: [PATCH] ARM: gic: Document Power and Clock Domain optional properties From: Geert Uytterhoeven To: Mark Rutland Cc: Geert Uytterhoeven , Rob Herring , Pawel Moll , Ian Campbell , Kumar Gala , Marc Zyngier , "devicetree@vger.kernel.org" , "linux-pm@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-sh@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Magnus Damm Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1559 Lines: 41 On Wed, Apr 29, 2015 at 5:15 PM, Mark Rutland wrote: >> > diff --git a/drivers/irqchip/irq-gic.c b/drivers/irqchip/irq-gic.c >> > index 7b315e3..02c8bb4 100644 >> > --- a/drivers/irqchip/irq-gic.c >> > +++ b/drivers/irqchip/irq-gic.c >> > @@ -959,6 +959,7 @@ void __init gic_init_bases(unsigned int gic_nr, int irq_start, >> > irq_hw_number_t hwirq_base; >> > struct gic_chip_data *gic; >> > int gic_irqs, irq_base, i; >> > + unsigned long iidr; >> > >> > BUG_ON(gic_nr >= MAX_GIC_NR); >> > >> > @@ -996,6 +997,9 @@ void __init gic_init_bases(unsigned int gic_nr, int irq_start, >> > gic_set_base_accessor(gic, gic_get_common_base); >> > } >> > >> > + iidr = readl_relaxed(gic_data_dist_base(gic) + GIC_DIST_IIDR); >> > + pr_info("GICD_IIDR reports 0x%08lx\n", (unsigned long)iidr); >> >> No need for the cast. > > For arm64 there is ;) Why? iidr is already unsigned long. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/