Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751740AbbD2S2c (ORCPT ); Wed, 29 Apr 2015 14:28:32 -0400 Received: from foss.arm.com ([217.140.101.70]:34072 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751055AbbD2S21 (ORCPT ); Wed, 29 Apr 2015 14:28:27 -0400 Date: Wed, 29 Apr 2015 19:28:17 +0100 From: Mark Rutland To: Geert Uytterhoeven Cc: Geert Uytterhoeven , Rob Herring , Pawel Moll , Ian Campbell , Kumar Gala , Marc Zyngier , "devicetree@vger.kernel.org" , "linux-pm@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-sh@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Magnus Damm Subject: Re: [PATCH] ARM: gic: Document Power and Clock Domain optional properties Message-ID: <20150429182817.GC17775@leverpostej> References: <1430146811-29862-1-git-send-email-geert+renesas@glider.be> <20150427155427.GB16191@leverpostej> <20150427171502.GD16191@leverpostej> <20150429125703.GB11757@leverpostej> <20150429151527.GA8781@leverpostej> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1455 Lines: 38 On Wed, Apr 29, 2015 at 07:12:32PM +0100, Geert Uytterhoeven wrote: > On Wed, Apr 29, 2015 at 5:15 PM, Mark Rutland wrote: > >> > diff --git a/drivers/irqchip/irq-gic.c b/drivers/irqchip/irq-gic.c > >> > index 7b315e3..02c8bb4 100644 > >> > --- a/drivers/irqchip/irq-gic.c > >> > +++ b/drivers/irqchip/irq-gic.c > >> > @@ -959,6 +959,7 @@ void __init gic_init_bases(unsigned int gic_nr, int irq_start, > >> > irq_hw_number_t hwirq_base; > >> > struct gic_chip_data *gic; > >> > int gic_irqs, irq_base, i; > >> > + unsigned long iidr; > >> > > >> > BUG_ON(gic_nr >= MAX_GIC_NR); > >> > > >> > @@ -996,6 +997,9 @@ void __init gic_init_bases(unsigned int gic_nr, int irq_start, > >> > gic_set_base_accessor(gic, gic_get_common_base); > >> > } > >> > > >> > + iidr = readl_relaxed(gic_data_dist_base(gic) + GIC_DIST_IIDR); > >> > + pr_info("GICD_IIDR reports 0x%08lx\n", (unsigned long)iidr); > >> > >> No need for the cast. > > > > For arm64 there is ;) > > Why? iidr is already unsigned long. Ah. indeed it is! For some reason I thought I'd left it as a u32. Sorry about that; I'll drop the cast. Thanks, Mark. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/