Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751513AbbD2Sgw (ORCPT ); Wed, 29 Apr 2015 14:36:52 -0400 Received: from mail-la0-f44.google.com ([209.85.215.44]:34845 "EHLO mail-la0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750808AbbD2Sgv (ORCPT ); Wed, 29 Apr 2015 14:36:51 -0400 MIME-Version: 1.0 In-Reply-To: References: <20150428181203.35812.60474.stgit@dwillia2-desk3.amr.corp.intel.com> <20150428182514.35812.12126.stgit@dwillia2-desk3.amr.corp.intel.com> From: Andy Lutomirski Date: Wed, 29 Apr 2015 11:36:29 -0700 Message-ID: Subject: Re: [Linux-nvdimm] [PATCH v2 11/20] libnd, nd_pmem: add libnd support to the pmem driver To: Dan Williams Cc: Phil Pokorny , linux-nvdimm , "linux-kernel@vger.kernel.org" , Christoph Hellwig , Jens Axboe , "H. Peter Anvin" , Ingo Molnar Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1704 Lines: 35 On Wed, Apr 29, 2015 at 8:55 AM, Dan Williams wrote: > On Tue, Apr 28, 2015 at 3:58 PM, Andy Lutomirski wrote: >> On Tue, Apr 28, 2015 at 3:21 PM, Phil Pokorny >> wrote: >>> On Tue, Apr 28, 2015 at 2:04 PM, Andy Lutomirski wrote: >>>> On Tue, Apr 28, 2015 at 11:25 AM, Dan Williams wrote: > [..] >> This is such a mess that I think this driver should maybe flat-out >> refuse to load in this type of configuration without some scary module >> option. I have some NVDIMMs that report as type 12 but need two extra >> out-of-tree drivers to work safely. First, they need i2c_imc or the >> equivalent (I'll try to resubmit that soon). Second, they need secret >> magic NDAed register poking. The latter is very problematic. >> >> At the very least, I think we should discourage people who don't >> really know what they're doing from using this driver without care. > > The benefit of the type-12 experiment having not made it very far out > of the lab is that it may be feasible to whitelist known platforms > where we believe ADR is available. Otherwise, the presence of the > NFIT asserts platform persistent memory support. This could be a good idea. I'm planning on resubmitting my i2c driver in the next couple weeks, and maybe I'll whitelist my own platform :) --Andy -- Andy Lutomirski AMA Capital Management, LLC -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/