Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752130AbbD2TVa (ORCPT ); Wed, 29 Apr 2015 15:21:30 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:50325 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751341AbbD2TV3 (ORCPT ); Wed, 29 Apr 2015 15:21:29 -0400 Date: Wed, 29 Apr 2015 15:21:26 -0400 (EDT) Message-Id: <20150429.152126.847523297244536648.davem@davemloft.net> To: kys@microsoft.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, devel@linuxdriverproject.org, olaf@aepfle.de, apw@canonical.com, jasowang@redhat.com Subject: Re: [PATCH V2 net 1/1] hv_netvsc: Fix a bug in netvsc_start_xmit() From: David Miller In-Reply-To: <1430269188-31701-1-git-send-email-kys@microsoft.com> References: <1430269188-31701-1-git-send-email-kys@microsoft.com> X-Mailer: Mew version 6.6 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 29 Apr 2015 12:21:29 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1080 Lines: 25 From: "K. Y. Srinivasan" Date: Tue, 28 Apr 2015 17:59:48 -0700 > Commit b08cc79155fc26d0d112b1470d1ece5034651a4b eliminated memory > allocation in the packet send path: > > "hv_netvsc: Eliminate memory allocation in the packet send path > > The network protocol used to communicate with the host is the remote ndis (rndis) > protocol. We need to decorate each outgoing packet with a rndis header and > additional rndis state (rndis per-packet state). To manage this state, we > currently allocate memory in the transmit path. Eliminate this allocation by > requesting additional head room in the skb." > > This commit introduced a bug since it did not account for the case if the skb > was cloned. Fix this bug. > > Signed-off-by: K. Y. Srinivasan Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/