Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751471AbbD2ViD (ORCPT ); Wed, 29 Apr 2015 17:38:03 -0400 Received: from bedivere.hansenpartnership.com ([66.63.167.143]:38134 "EHLO bedivere.hansenpartnership.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750905AbbD2Vh6 (ORCPT ); Wed, 29 Apr 2015 17:37:58 -0400 Message-ID: <1430343476.2189.28.camel@HansenPartnership.com> Subject: Re: [PATCH v4 2/2] efi: an sysfs interface for user to update efi firmware From: James Bottomley To: Andy Lutomirski Cc: "Kweh, Hock Leong" , Peter Jones , Greg Kroah-Hartman , Matt Fleming , Ming Lei , "Ong, Boon Leong" , LKML , "linux-efi@vger.kernel.org" , Sam Protsenko , Roy Franz , Borislav Petkov , Al Viro , Linux FS Devel Date: Wed, 29 Apr 2015 14:37:56 -0700 In-Reply-To: References: <20150415131906.GC21491@kroah.com> <20150417134924.GB19794@kroah.com> <20150417143640.GB3671@codeblueprint.co.uk> <20150420144323.GA7261@kroah.com> <20150421075620.GA11000@kroah.com> <1429665679.2207.44.camel@HansenPartnership.com> <20150422132734.GB12062@redhat.com> <1429715913.2195.22.camel@HansenPartnership.com> <1429798187.2170.3.camel@HansenPartnership.com> <1429888575.2182.20.camel@HansenPartnership.com> <1430174136.2314.49.camel@HansenPartnership.com> <1430175112.2314.56.camel@HansenPartnership.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.11 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1002 Lines: 24 On Wed, 2015-04-29 at 11:40 -0700, Andy Lutomirski wrote: > If it works (and cat really does fail reliably), then it seems okay to me. > > However, since I like pulling increasing numbers of my hats, someone > should verify that the common embedded cat implementations are also > okay with this. For example, I haven't yet found any code in > busybox's cat implementation that closes stdout. > > Given that the main targets of this (for now, at least) are embedded, > this might be a problem. I think that rabbit is a bit mixie: we already demonstrated we *can* collect the error in close. It's up to the fw vendors who want to use this method to make sure they have proper tools (and if busybox cat needs fixing, to fix it before they ship). James -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/