Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751876AbbD2XHy (ORCPT ); Wed, 29 Apr 2015 19:07:54 -0400 Received: from smtp6-g21.free.fr ([212.27.42.6]:35781 "EHLO smtp6-g21.free.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751306AbbD2XHt (ORCPT ); Wed, 29 Apr 2015 19:07:49 -0400 Date: Thu, 30 Apr 2015 01:07:28 +0200 From: Alban To: Ezequiel Garcia Cc: Aban Bedel , linux-mips@linux-mips.org, Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Thomas Gleixner , Jason Cooper , Ralf Baechle , Andrew Bresticker , Qais Yousef , Gabor Juhos , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 00/12] MIPS: ath79: Add OF support and DTS for TL-WR1043ND Message-ID: <20150430010728.0331a736@tock> In-Reply-To: <553E3CC8.3070304@vanguardiasur.com.ar> References: <1429875679-14973-1-git-send-email-albeu@free.fr> <553E3CC8.3070304@vanguardiasur.com.ar> X-Mailer: Claws Mail 3.9.3 (GTK+ 2.24.23; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1662 Lines: 52 On Mon, 27 Apr 2015 10:42:32 -0300 Ezequiel Garcia wrote: > On 04/24/2015 08:41 AM, Alban Bedel wrote: > > This series add OF bindings and code support for the interrupt > > controllers, clocks and GPIOs. However it was only tested on a > > TL-WR1043ND with an AR9132, others SoCs are untested, and a few are > > not supported at all. > > > Hi Alban, Hi, > I've booted a Carambola2 using this (plus a custom devicetree and some > small changes): > > Tested-by: Ezequiel Garcia > > Just a small comment/question: Shouldn't we allow to build all the > devicetree files, instead of just the one that will be built-in? > > I.e., something like this: > > dtb-$(CONFIG_MATCH_ATH79_DT) += ar9132_tl_wr1043nd_v1.dtb > dtb-$(CONFIG_MACH_ATH79_DT) += ar9331_carambola2.dtb > > It should be useful to catch errors, but also in general, as the > devicetree is supposed to be independent of the kernel and should be > built separate from it. Yes, that would be better, I'll fix that. > PS: This series depends on a previous patchset. It's usually useful to > mention this in the cover letter and make a poor tester's life > easier :) > > Most code changes base on the previous bug fix series: > > [PATCH v2 0/5] MIPS: ath79: Various small fix to prepare OF support Wasn't that clear enough? > Thanks for the work, Thanks for the testing. Alban -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/