Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751973AbbD2XkT (ORCPT ); Wed, 29 Apr 2015 19:40:19 -0400 Received: from mail-la0-f43.google.com ([209.85.215.43]:35559 "EHLO mail-la0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751409AbbD2XkQ (ORCPT ); Wed, 29 Apr 2015 19:40:16 -0400 MIME-Version: 1.0 In-Reply-To: <1430350592.2189.50.camel@HansenPartnership.com> References: <1430348859.2189.37.camel@HansenPartnership.com> <1430349130.2189.43.camel@HansenPartnership.com> <1430350592.2189.50.camel@HansenPartnership.com> From: Andy Lutomirski Date: Wed, 29 Apr 2015 16:39:54 -0700 Message-ID: Subject: Re: [RFC 3/3] efi: add capsule update capability via sysfs To: James Bottomley Cc: "linux-efi@vger.kernel.org" , "Kweh, Hock Leong" , LKML , Greg Kroah-Hartman , Peter Jones Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1517 Lines: 37 On Wed, Apr 29, 2015 at 4:36 PM, James Bottomley wrote: > On Wed, 2015-04-29 at 16:25 -0700, Andy Lutomirski wrote: >> On Wed, Apr 29, 2015 at 4:12 PM, James Bottomley >> wrote: >> > From: James Bottomley >> > >> > The firmware update should be applied simply by doing >> > >> > cat fw_file > /sys/firmware/capsule/update >> > >> > With a properly formatted fw_file. Any error will be returned on close of >> > stdout. util-linux returns errors correctly from closing stdout, but firmware >> > shippers should check whatever utilities package they use correctly captures >> > the error return on close. >> >> s/util-linux/coreutils/ >> >> This still makes my API sense itch. It's kind of an abuse of >> open/write/close. > > It works ... and according to Alan, NFS is already doing it. I suppose > we can have a do over of the whole debate again ... I think that NFS is at least writing to actual files as opposed to trying to implement some kind of transactions. Blech, whatever. This approach certainly works, as long as no one trips over the busybox thing. Maybe there should also be /sys/something_that_errors_on_close that people can use as a test. --Andy -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/