Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751957AbbD3Acg (ORCPT ); Wed, 29 Apr 2015 20:32:36 -0400 Received: from bhuna.collabora.co.uk ([93.93.135.160]:55761 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751160AbbD3Acd (ORCPT ); Wed, 29 Apr 2015 20:32:33 -0400 Message-ID: <55417810.6070202@collabora.co.uk> Date: Thu, 30 Apr 2015 02:32:16 +0200 From: Javier Martinez Canillas User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.2.0 MIME-Version: 1.0 To: Kukjin Kim , kgene.kim@samsung.com CC: Doug Anderson , Olof Johansson , Krzysztof Kozlowski , Andrzej Hajda , Kevin Hilman , Tyler Baker , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] ARM: dts: Make DP a consumer of DISP1 power domain on Exynos5420 References: <1428870659-5525-1-git-send-email-javier.martinez@collabora.co.uk> <552F6750.6020306@collabora.co.uk> In-Reply-To: <552F6750.6020306@collabora.co.uk> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1795 Lines: 46 Hello Kukjin, On 04/16/2015 09:40 AM, Javier Martinez Canillas wrote: > > On 04/12/2015 10:30 PM, Javier Martinez Canillas wrote: >> Commit ea08de16eb1b ("ARM: dts: Add DISP1 power domain for exynos5420") >> added a device node for the Exynos5420 DISP1 power domain but dit not >> make the DP controller a consumer of that power domain. >> >> This causes an "Unhandled fault: imprecise external abort" error if the >> exynos-dp driver tries to access the DP controller registers and the PD >> was turned off. This lead to a kernel panic and a complete system hang. >> >> Make the DP controller device node a consumer of the DISP1 power domain >> to ensure that the PD is turned on when the exynos-dp driver is probed. >> >> Fixes: ea08de16eb1b ("ARM: dts: Add DISP1 power domain for exynos5420") >> Signed-off-by: Javier Martinez Canillas > > Any comments about this patch? > > It's very trivial but fixes a very important regression on Exynos5420 boards > with display panel and Peach Pit and Pi have been broken since next-20150401. > > This [0] is the Peach Pit boot log with yesteday's linux-next for example. > > Best regards, > Javier > > [0]: http://arm-soc.lixom.net/bootlogs/next/next-20150415/pit-arm-exynos_defconfig.html > It has been many weeks since this patch has been posted and linux-next is still broken: http://arm-soc.lixom.net/bootlogs/next/next-20150429/pi-arm-exynos_defconfig.html Could you please apply $subject to fix the imprecise external abort issue. Best regards, Javier -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/