Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751947AbbD3Ca5 (ORCPT ); Wed, 29 Apr 2015 22:30:57 -0400 Received: from mail-pd0-f181.google.com ([209.85.192.181]:32794 "EHLO mail-pd0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751262AbbD3Ca4 (ORCPT ); Wed, 29 Apr 2015 22:30:56 -0400 Message-ID: <554193D9.5010209@ozlabs.ru> Date: Thu, 30 Apr 2015 12:30:49 +1000 From: Alexey Kardashevskiy User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: David Gibson CC: linuxppc-dev@lists.ozlabs.org, Benjamin Herrenschmidt , Paul Mackerras , Alex Williamson , Gavin Shan , linux-kernel@vger.kernel.org Subject: Re: [PATCH kernel v9 12/32] powerpc/spapr: vfio: Switch from iommu_table to new iommu_table_group References: <1429964096-11524-1-git-send-email-aik@ozlabs.ru> <1429964096-11524-13-git-send-email-aik@ozlabs.ru> <20150429024959.GI32589@voom.redhat.com> In-Reply-To: <20150429024959.GI32589@voom.redhat.com> Content-Type: text/plain; charset=koi8-r; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1467 Lines: 42 On 04/29/2015 12:49 PM, David Gibson wrote: > On Sat, Apr 25, 2015 at 10:14:36PM +1000, Alexey Kardashevskiy wrote: >> Modern IBM POWERPC systems support multiple (currently two) TCE tables >> per IOMMU group (a.k.a. PE). This adds a iommu_table_group container >> for TCE tables. Right now just one table is supported. >> >> For P5IOC2 and IODA, iommu_table_group is embedded into PE struct >> (pnv_ioda_pe and pnv_phb) and does not require iommu_free_table(), only . >> iommu_reset_table(). >> >> For pSeries, this replaces multiple calls of kzalloc_node() with a new >> iommu_pseries_group_alloc() helper and stores the table group struct >> pointer into the pci_dn struct. For release, a iommu_table_group_free() >> helper is added. >> >> This should cause no behavioural change. >> >> Signed-off-by: Alexey Kardashevskiy >> [aw: for the vfio related changes] >> Acked-by: Alex Williamson > > I'm not particularly fond of the "table_group" name, but I can't > really think of a better name for now. So, I asked Ben again. iommu_state is not much better either. I'd stick to iommu_table_group. > Reviewed-by: David Gibson -- Alexey -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/