Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751150AbbD3EgI (ORCPT ); Thu, 30 Apr 2015 00:36:08 -0400 Received: from mail-oi0-f49.google.com ([209.85.218.49]:36007 "EHLO mail-oi0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750764AbbD3EgG (ORCPT ); Thu, 30 Apr 2015 00:36:06 -0400 MIME-Version: 1.0 In-Reply-To: <554112B9.2060102@linux.vnet.ibm.com> References: <1430236283-29360-1-git-send-email-shreyas@linux.vnet.ibm.com> <1430236283-29360-3-git-send-email-shreyas@linux.vnet.ibm.com> <5540EF78.8000409@linux.vnet.ibm.com> <20150429111812.60b697c6@gandalf.local.home> <5540FFAE.2050502@linux.vnet.ibm.com> <20150429130852.487100d9@gandalf.local.home> <554112B9.2060102@linux.vnet.ibm.com> Date: Thu, 30 Apr 2015 10:06:05 +0530 Message-ID: Subject: Re: [PATCH 3/3] tracing/mm: Don't trace mm_page_pcpu_drain on offline cpus From: Preeti Murthy To: Shreyas B Prabhu Cc: Steven Rostedt , Paul McKenney , LKML , Ingo Molnar , aneesh.kumar@linux.vnet.ibm.com, Preeti U Murthy Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1060 Lines: 31 On Wed, Apr 29, 2015 at 10:49 PM, Shreyas B Prabhu wrote: > > > On Wednesday 29 April 2015 10:38 PM, Steven Rostedt wrote: >>> I am not sure if its worth the effort now. It doesn't look like any >>> other trace point apart from the above use case will benefit from it. >>> Only smbus_write and smbus_reply seem to come close. But even they need >>> separate TP_fast_assign. >> >> It shouldn't be a problem to implement. But I'm currently cleaning up >> those files, and any changes will cause nasty conflicts. >> >> Lets do this. Push the current changes as is, and when I get around to >> adding a DEFINE_EVENT_PRINT_CONDITION(), we can modify that code to use >> it. >> > Okay, sure. Looks good then. Reviewed-by: Preeti U Murthy > > Thanks, > Shreyas > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/