Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751128AbbD3Emg (ORCPT ); Thu, 30 Apr 2015 00:42:36 -0400 Received: from e23smtp09.au.ibm.com ([202.81.31.142]:46766 "EHLO e23smtp09.au.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750785AbbD3Emc (ORCPT ); Thu, 30 Apr 2015 00:42:32 -0400 Message-ID: <5541B27F.5040200@linux.vnet.ibm.com> Date: Thu, 30 Apr 2015 10:11:35 +0530 From: Shreyas B Prabhu User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.0 MIME-Version: 1.0 To: Preeti Murthy CC: Steven Rostedt , Paul McKenney , LKML , Ingo Molnar , aneesh.kumar@linux.vnet.ibm.com, Preeti U Murthy Subject: Re: [PATCH 3/3] tracing/mm: Don't trace mm_page_pcpu_drain on offline cpus References: <1430236283-29360-1-git-send-email-shreyas@linux.vnet.ibm.com> <1430236283-29360-3-git-send-email-shreyas@linux.vnet.ibm.com> <5540EF78.8000409@linux.vnet.ibm.com> <20150429111812.60b697c6@gandalf.local.home> <5540FFAE.2050502@linux.vnet.ibm.com> <20150429130852.487100d9@gandalf.local.home> <554112B9.2060102@linux.vnet.ibm.com> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15043004-0033-0000-0000-0000016A879A Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1139 Lines: 33 On Thursday 30 April 2015 10:06 AM, Preeti Murthy wrote: > On Wed, Apr 29, 2015 at 10:49 PM, Shreyas B Prabhu > wrote: >> >> >> On Wednesday 29 April 2015 10:38 PM, Steven Rostedt wrote: >>>> I am not sure if its worth the effort now. It doesn't look like any >>>> other trace point apart from the above use case will benefit from it. >>>> Only smbus_write and smbus_reply seem to come close. But even they need >>>> separate TP_fast_assign. >>> >>> It shouldn't be a problem to implement. But I'm currently cleaning up >>> those files, and any changes will cause nasty conflicts. >>> >>> Lets do this. Push the current changes as is, and when I get around to >>> adding a DEFINE_EVENT_PRINT_CONDITION(), we can modify that code to use >>> it. >>> >> Okay, sure. > > Looks good then. > > Reviewed-by: Preeti U Murthy Thanks a lot! -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/