Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750959AbbD3F7I (ORCPT ); Thu, 30 Apr 2015 01:59:08 -0400 Received: from sender1.zohomail.com ([74.201.84.155]:35216 "EHLO sender1.zohomail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750705AbbD3F7F (ORCPT ); Thu, 30 Apr 2015 01:59:05 -0400 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=zapps768; d=zoho.com; h=date:from:to:cc:subject:message-id:references:mime-version:content-type:in-reply-to; b=q6pdIv4Z7wlZ/nl6vBGh7XyfFjATovbYKX1nvsfERGh/g/8c6OXXZ8bSyjBxHKN8QgTJuSgla/DI Gx8rCz//+E06jw+Z/2Mo0VnMH5KN/dKRnulgO9NBOSLEjNWfe+6k Date: Thu, 30 Apr 2015 05:58:48 +0000 From: mancha security To: Pranith Kumar Cc: Daniel Borkmann , "H. Peter Anvin" , LKML , Ingo Molnar Subject: Re: [PATCH] compiler-intel: fix wrong compiler barrier() macro Message-ID: <20150430055848.GC12861@zoho.com> References: <20150429145956.GB12861@zoho.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="raC6veAxrt5nqIoY" Content-Disposition: inline In-Reply-To: X-PGP-Key: http://hkps.pool.sks-keyservers.net/pks/lookup?op=vindex&search=0x25168eb24f0b22ac X-PGP-FP: 56B7 100E F4D5 811C 8FEF ADD1 2516 8EB2 4F0B 22AC X-Zoho-Virus-Status: 1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1957 Lines: 54 --raC6veAxrt5nqIoY Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Apr 29, 2015 at 12:40:15PM -0400, Pranith Kumar wrote: > On Wed, Apr 29, 2015 at 10:59 AM, mancha security > wrote: > > > > The problem is that ICC defines __GNUC__ so barrier() gets defined > > in compiler-gcc.h. Your commit removed an #undef from > > compiler-intel.h so compiler.h will never define barrier to > > __memory_barrier(). > > >=20 > OK, I see your point. But, ICC has support for GCC inline assembly. So > the change does not seem to be making any difference. We are using our > own asm barrier rather than the inbuilt one provided by ICC. >=20 > -- Pranith Yes, I misspoke earlier and meant to say ECC rather than ICC. --mancha --raC6veAxrt5nqIoY Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBCgAGBQJVQcSYAAoJEB4VYy8JqhaD2CsQAJmqPNBcWDrucZEeGHsbM43v hWiC1MJKLxv42fazMqNDANt4tIizL4J6kFicEOy3T/xfgg0Jl9DVlqESJGNC0Njg fNxQjAlCcdhEhf4RrCYfaMiC+hGmSMarrYB+ZXLD4+1yfqIgArWiYE8yeyCIOyZe +KhoUrq5qcTAh0m45heOopXiWWBGgn9QgV9TeRDIh9iQjTHdwqXzQ8FErCX8z2PP eEVH4h3MRYEhyjKdXE5H639nBhPz1tCIN+/hQL2mW5lW0bew1l9TwA+4U1OUcdw1 uf2ZCcHwe74bWlXVNzVk2BqjiFkxxDA3GcTwImfs/CfKofMZzsEdSqrElyvdR6Q2 pcEM04Y+/e9+v3MN9yuLnFhr+uyUXjzqDokQqOhSAfWynzz7ke4uOTjzrHVlXjji zhr8PXeNWB6gwjMAolBVGU5QAJDJg8Ne1PNnLipjmgnbNHklm8mwWPq9Nw4zo6qt lZKkYhJyQmZ/YO+10aeG7MEfhyWCxsov0MJ02+YovYfOFNXHMvr072/fnatJ42Ed 1IYiS8D2oRHzuEZ5YLA5P7OGmPxycUioNtqSQzlnFtx6O8ZZyxObnOUD3GVESExs vyoIXXaXyxKACMGTUojUKqj99nq1e001wsgY5lTsOtpvuLdmcIcepelhSX177Bbq 6BUKrhdZE9O20crkhGJ5 =/jUn -----END PGP SIGNATURE----- --raC6veAxrt5nqIoY-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/