Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751777AbbD3Gi4 (ORCPT ); Thu, 30 Apr 2015 02:38:56 -0400 Received: from mail-ob0-f182.google.com ([209.85.214.182]:36153 "EHLO mail-ob0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751472AbbD3Giw (ORCPT ); Thu, 30 Apr 2015 02:38:52 -0400 MIME-Version: 1.0 In-Reply-To: <1430213037-23831-2-git-send-email-yingjoe.chen@mediatek.com> References: <1430213037-23831-1-git-send-email-yingjoe.chen@mediatek.com> <1430213037-23831-2-git-send-email-yingjoe.chen@mediatek.com> From: Daniel Kurtz Date: Thu, 30 Apr 2015 14:38:31 +0800 X-Google-Sender-Auth: vwoUHjcpvCq9A2pswgH093ihF7o Message-ID: Subject: Re: [PATCH 2/2] arm64: dts: mt8173: Fixup pinctrl nodes To: Yingjoe Chen Cc: Matthias Brugger , Rob Herring , Mark Rutland , Russell King , Catalin Marinas , Will Deacon , Hongzhou Yang , Eddie Huang , "linux-arm-kernel@lists.infradead.org" , linux-mediatek@lists.infradead.org, "open list:OPEN FIRMWARE AND..." , "linux-kernel@vger.kernel.org" , Sascha Hauer , srv_heupstream@mediatek.com Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2865 Lines: 69 On Tue, Apr 28, 2015 at 5:23 PM, Yingjoe Chen wrote: > > The 8173 pinctrl node doesn't follow dts convention. Fix them. > Also add a comment to explain pinctrl register usage to make it > more clear. > > Signed-off-by: Yingjoe Chen Thanks for the fix. Reviewed-by: Daniel Kurtz > > --- > arch/arm64/boot/dts/mediatek/mt8173.dtsi | 13 +++++++++---- > 1 file changed, 9 insertions(+), 4 deletions(-) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi > index 8346c0f..e4a30cd 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi > @@ -128,6 +128,7 @@ > compatible = "simple-bus"; > ranges; > > + /* Provide regmap for pinctrl driver */ > syscfg_pctl_a: syscfg_pctl_a@10005000 { > compatible = "mediatek,mt8173-pctl-a-syscfg", "syscon"; > reg = <0 0x10005000 0 0x1000>; > @@ -159,9 +160,13 @@ > #reset-cells = <1>; > }; > > - pio: pinctrl@0x10005000 { > + /* > + * Pinctrl access register at 0x10005000 through regmap. > + * Register 0x1000b000 is used by EINT. > + */ > + pio: pinctrl@10005000 { > compatible = "mediatek,mt8173-pinctrl"; > - reg = <0 0x1000B000 0 0x1000>; > + reg = <0 0x1000b000 0 0x1000>; > mediatek,pctl-regmap = <&syscfg_pctl_a>; > pins-are-numbered; > gpio-controller; > @@ -169,8 +174,8 @@ > interrupt-controller; > #interrupt-cells = <2>; > interrupts = , > - , > - ; > + , > + ; > }; > > sysirq: intpol-controller@10200620 { > -- > 1.8.1.1.dirty > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/