Message-ID: <5541DFF9.9050205@electrozaur.com>
Date: Thu, 30 Apr 2015 10:55:37 +0300
From: Boaz Harrosh <ooo@electrozaur.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0
MIME-Version: 1.0
To: Fabian Frederick <fabf@skynet.be>, linux-kernel@vger.kernel.org
CC: Alexander Viro <viro@zeniv.linux.org.uk>,
        Benny Halevy <bhalevy@primarydata.com>, osd-dev@open-osd.org
Subject: Re: [PATCH 1/1 linux-next] exofs: convert simple_str to kstr
References: <1430330330-17481-1-git-send-email-fabf@skynet.be>
In-Reply-To: <1430330330-17481-1-git-send-email-fabf@skynet.be>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1551
Lines: 55

On 04/29/2015 08:58 PM, Fabian Frederick wrote:
> replace obsolete function.
> 
> Signed-off-by: Fabian Frederick <fabf@skynet.be>

Thanks.
ACK-by: Boaz Harrosh <ooo@electrozaur.com>

Are you pushing all these through some tree, or
You need that I push it? Maybe push all these changes
through some central place, like Andrew's tree?

Boaz

> ---
> This is untested.
> 
>  fs/exofs/super.c | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/fs/exofs/super.c b/fs/exofs/super.c
> index b795c56..b667f73 100644
> --- a/fs/exofs/super.c
> +++ b/fs/exofs/super.c
> @@ -108,9 +108,14 @@ static int parse_options(char *options, struct exofs_mountopt *opts)
>  			opts->is_osdname = true;
>  			break;
>  		case Opt_pid:
> +		{
> +			int rc;
> +
>  			if (0 == match_strlcpy(str, &args[0], sizeof(str)))
>  				return -EINVAL;
> -			opts->pid = simple_strtoull(str, NULL, 0);
> +			rc = kstrtoull(str, 0, &opts->pid);
> +			if (rc)
> +				return rc;
>  			if (opts->pid < EXOFS_MIN_PID) {
>  				EXOFS_ERR("Partition ID must be >= %u",
>  					  EXOFS_MIN_PID);
> @@ -118,6 +123,7 @@ static int parse_options(char *options, struct exofs_mountopt *opts)
>  			}
>  			s_pid = 1;
>  			break;
> +		}
>  		case Opt_to:
>  			if (match_int(&args[0], &option))
>  				return -EINVAL;
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/