Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751393AbbD3I4H (ORCPT ); Thu, 30 Apr 2015 04:56:07 -0400 Received: from mx07-00178001.pphosted.com ([62.209.51.94]:51895 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751095AbbD3I4A (ORCPT ); Thu, 30 Apr 2015 04:56:00 -0400 Message-ID: <5541EE00.4070500@st.com> Date: Thu, 30 Apr 2015 10:55:28 +0200 From: Maxime Coquelin User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Ulf Hansson CC: Peter Griffin , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Patrice CHOTARD , Giuseppe Cavallaro , Lee Jones , "devicetree@vger.kernel.org" , linux-mmc Subject: Re: [PATCH v5 0/9] Add sd/emmc support for stih407 family silicon References: <1428658831-14308-1-git-send-email-peter.griffin@linaro.org> <5541E7C5.1000903@st.com> In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.201.23.80] X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.13.68,1.0.33,0.0.0000 definitions=2015-04-30_02:2015-04-29,2015-04-30,1970-01-01 signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 4211 Lines: 108 On 04/30/2015 10:51 AM, Ulf Hansson wrote: > On 30 April 2015 at 10:28, Maxime Coquelin wrote: >> Hi Ulf, >> >> >> On 04/10/2015 01:06 PM, Ulf Hansson wrote: >>> On 10 April 2015 at 11:40, Peter Griffin wrote: >>>> Hi, >>>> >>>> This series adds sd/emmc support to the sdhci-st.c driver for stih407 >>>> family silicon. The changes mainly involve configuring some extra glue >>>> registers in the flashSS which configure the Arasan controller. >>>> >>>> This series also adds support for UHS modes for eMMC. To allow >>>> UHS HS200/SD104 modes to function correctly, due to the >>>> tight timing constriants, support for delay management is also added. >>>> Two types of delay management are supported, static delay management and >>>> dynamic delay management, this delay management is only available >>>> on eMMC pads on stih410 and later silicon. >>>> >>>> This series has been tested with stih410-b2120 revd on eMMC and sd, at >>>> various clock speeds. As part of this testing a bug was also found in the >>>> upstream flexgen clock set_rate implementation (now fixed upstream). >>>> >>>> max-frequency = 200Mhz >>>> /dev/mmcblk0p1: >>>> Timing buffered disk reads: 270 MB in 3.02 seconds = 89.54 MB/sec >>>> >>>> max-frequency = 100Mhz >>>> root@debian-armhf:~# hdparm -t /dev/mmcblk0p1 >>>> /dev/mmcblk0p1: >>>> Timing buffered disk reads: 210 MB in 3.00 seconds = 70.00 MB/sec >>>> >>>> max-frequency = 50Mhz >>>> root@debian-armhf:~# hdparm -t /dev/mmcblk0p1 >>>> /dev/mmcblk0p1: >>>> Timing buffered disk reads: 118 MB in 3.00 seconds = 39.28 MB/sec >>>> >>>> It has also been tested on stih416-b2020 to ensure we have caused no >>>> regressions. Finally the dt documentation has been updated to reflect >>>> the changes in the driver code. Intrestingly it seems we are the first >>>> upstream platform to be using some of the uhs bindings such as >>>> sd-uhs-sdr104. >>>> >>>> Changes since v4: >>>> - Fixup typo (Pete) >>>> >>>> Changes since v3: >>>> - Rebased on Ulf's mmc next branch (rc5 based) (Ulf) >>>> >>>> Changes since v2: >>>> - Some whitespace fixups (Max) >>>> - if (!ioaddr) suggestion (Max) >>>> - Add stih418-b2199 suport (Max) >>>> - Stih410 to STiH410 fixes (Max) >>>> - rebased on v4.0-rc6 (Pete) >>>> >>>> Changes since v1: >>>> - Partition the changes into smaller patches to aid review process >>>> (Ulf) >>>> >>>> Peter Griffin (9): >>>> mmc: sdhci-st: Add macros for register offsets and bitfields for mmcss >>>> glue regs >>>> mmc: sdhci-st: Add support for de-asserting reset signal and top regs >>>> resource >>>> mmc: sdhci-st: Add delay management functions for top registers >>>> (eMMC). >>>> mmc: sdhci-st: Add st_mmcss_cconfig function to configure mmcss glue >>>> registers. >>>> mmc: sdhci-st: Add sdhci_st_set_uhs_signaling function. >>>> mmc: sdhci-st: Update the quirks for this controller. >>>> mmc: sdhci-st: Update ST SDHCI binding documentation. >>>> ARM: STi: DT: STiH407: Add dt nodes for sdhci and emmc. >>>> ARM: STi: DT: STiH418: Add dt nodes for sdhci and emmc. >>>> >>>> Documentation/devicetree/bindings/mmc/sdhci-st.txt | 100 +++++- >>>> arch/arm/boot/dts/stih407-family.dtsi | 30 ++ >>>> arch/arm/boot/dts/stih410-b2120.dts | 10 + >>>> arch/arm/boot/dts/stih418-b2199.dts | 12 + >>>> arch/arm/boot/dts/stihxxx-b2120.dtsi | 8 + >>>> drivers/mmc/host/sdhci-st.c | 354 >>>> ++++++++++++++++++++- >>>> 6 files changed, 500 insertions(+), 14 deletions(-) >>>> >>>> -- >>>> 1.9.1 >>>> >>> Thanks! Applied. >> Do you confirm you didn't applied the DT patches? >> > Correct. Sorry if that was unclear. No problem, thanks for the clarification. Best regards, Maxime > > Kind regards > Uffe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/