Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751225AbbD3JbF (ORCPT ); Thu, 30 Apr 2015 05:31:05 -0400 Received: from mga03.intel.com ([134.134.136.65]:36411 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751158AbbD3JbB (ORCPT ); Thu, 30 Apr 2015 05:31:01 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.11,676,1422950400"; d="scan'208";a="487595903" From: "Kweh, Hock Leong" To: James Bottomley , "linux-efi@vger.kernel.org" CC: LKML , Andy Lutomirski , Greg Kroah-Hartman , Peter Jones , Matt Fleming , "Ong, Boon Leong" Subject: RE: [RFC 0/3] Add capsule update using error on close semantics Thread-Topic: [RFC 0/3] Add capsule update using error on close semantics Thread-Index: AQHQgtFQV6ZL6tIBqEGcy1HoimDux51lQJYw Date: Thu, 30 Apr 2015 09:30:53 +0000 Message-ID: References: <1430348859.2189.37.camel@HansenPartnership.com> In-Reply-To: <1430348859.2189.37.camel@HansenPartnership.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.30.20.206] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id t3U9V9NU032349 Content-Length: 2309 Lines: 53 > -----Original Message----- > From: James Bottomley [mailto:James.Bottomley@HansenPartnership.com] > Sent: Thursday, April 30, 2015 7:08 AM > To: linux-efi@vger.kernel.org > Cc: Kweh, Hock Leong; LKML; Andy Lutomirski; Greg Kroah-Hartman; Peter > Jones > Subject: [RFC 0/3] Add capsule update using error on close semantics > > This is a straw man implementation. The three patches firstly thread the > needed ->flush() file op through sysfs and kernfs. The next one extracts > transaction buffer handling from firmware_class.c and makes it generic in a > lib helper and the third patch adds a bare bones capsule update (I suspect > the latter needs more work, since it doesn't implement the scatterlist). > > James Bottomley (3): > sysfs,kernfs: add flush operation > firmware_class: split out transaction helpers > efi: add capsule update capability via sysfs > > drivers/base/firmware_class.c | 117 ++++--------------------------- > drivers/firmware/efi/Makefile | 2 +- > drivers/firmware/efi/capsule.c | 78 +++++++++++++++++++++ > drivers/firmware/efi/capsule.h | 2 + > drivers/firmware/efi/efi.c | 8 +++ > fs/kernfs/file.c | 16 +++++ > fs/sysfs/file.c | 16 +++++ > include/linux/kernfs.h | 2 + > include/linux/sysfs.h | 2 + > include/linux/transaction_helper.h | 26 +++++++ > lib/Makefile | 2 +- > lib/transaction_helper.c | 137 > +++++++++++++++++++++++++++++++++++++ > 12 files changed, 304 insertions(+), 104 deletions(-) create mode 100644 > drivers/firmware/efi/capsule.c create mode 100644 > drivers/firmware/efi/capsule.h create mode 100644 > include/linux/transaction_helper.h > create mode 100644 lib/transaction_helper.c > > James Hi James, I like the sysfs enhancement but require Greg to buy in the idea. For the efi capsule part, Matt has implemented some APIs where you could get the patch at http://permalink.gmane.org/gmane.linux.kernel.efi/4837. So, I would think that leveraging the APIs that Matt has created is a better choice. Thanks & Regards, Wilson ????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m???? ????????I?