Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751419AbbD3J4u (ORCPT ); Thu, 30 Apr 2015 05:56:50 -0400 Received: from www62.your-server.de ([213.133.104.62]:42814 "EHLO www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750933AbbD3J4p (ORCPT ); Thu, 30 Apr 2015 05:56:45 -0400 From: Daniel Borkmann To: hpa@linux.intel.com Cc: linux-kernel@vger.kernel.org, Daniel Borkmann , Pranith Kumar , Ingo Molnar , mancha security Subject: [PATCH v2] compiler-intel: fix wrong compiler barrier() macro Date: Thu, 30 Apr 2015 11:56:32 +0200 Message-Id: <7c08c18c742415f32e022c43614a274135e79012.1430387496.git.daniel@iogearbox.net> X-Mailer: git-send-email 1.9.3 X-Authenticated-Sender: daniel@iogearbox.net Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2028 Lines: 57 Cleanup commit 73679e508201 ("compiler-intel.h: Remove duplicate definition") removed the double definition of __memory_barrier() intrinsics. However, in doing so, it also removed the preceding #undef barrier by accident, meaning, the actual barrier() macro from compiler-gcc.h with inline asm is still in place as __GNUC__ is provided. Subsequently, barrier() can never be defined as __memory_barrier() from compiler.h since it already has a definition in place and if we trust the comment in compiler-intel.h, ecc doesn't support gcc specific asm statements. I don't have an ecc at hand, so a revert of that cleanup would be the safest option, imho, as it has been like this since pre git times. Fixes: 73679e508201 ("compiler-intel.h: Remove duplicate definition") Signed-off-by: Daniel Borkmann Reviewed-by: Pranith Kumar Cc: Pranith Kumar Cc: H. Peter Anvin Cc: Ingo Molnar Cc: mancha security --- v1->v2: - fixed the wrong commit hash in 1st occurence of commit msg - rest as is, also kept Pranith's Reviewed-by tag include/linux/compiler-intel.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/linux/compiler-intel.h b/include/linux/compiler-intel.h index ba147a1..5529c52 100644 --- a/include/linux/compiler-intel.h +++ b/include/linux/compiler-intel.h @@ -13,9 +13,12 @@ /* Intel ECC compiler doesn't support gcc specific asm stmts. * It uses intrinsics to do the equivalent things. */ +#undef barrier #undef RELOC_HIDE #undef OPTIMIZER_HIDE_VAR +#define barrier() __memory_barrier() + #define RELOC_HIDE(ptr, off) \ ({ unsigned long __ptr; \ __ptr = (unsigned long) (ptr); \ -- 1.9.3 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/