Date: Thu, 30 Apr 2015 11:08:49 +0100
From: Lee Jones <lee.jones@linaro.org>
To: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Cc: sameo@linux.intel.com, broonie@kernel.org, lgirdwood@gmail.com,
        patches@opensource.wolfsonmicro.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 10/10] mfd: wm5110: Add delay before releasing reset
 line
Message-ID: <20150430100849.GD1815@x1>
References: <1430387287-27777-1-git-send-email-ckeepax@opensource.wolfsonmicro.com>
 <1430387287-27777-11-git-send-email-ckeepax@opensource.wolfsonmicro.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1430387287-27777-11-git-send-email-ckeepax@opensource.wolfsonmicro.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1445
Lines: 45

On Thu, 30 Apr 2015, Charles Keepax wrote:

> On the wm5110 it is important the reset line is held for slightly longer
> to ensure the device starts up well. This patch adds a 5mS delay for
> this.
> 
> Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
> ---
>  drivers/mfd/arizona-core.c |   10 ++++++++++
>  1 files changed, 10 insertions(+), 0 deletions(-)

Acked-by: Lee Jones <lee.jones@linaro.org>

> diff --git a/drivers/mfd/arizona-core.c b/drivers/mfd/arizona-core.c
> index f1ff68a..93e4d94 100644
> --- a/drivers/mfd/arizona-core.c
> +++ b/drivers/mfd/arizona-core.c
> @@ -259,6 +259,16 @@ static inline void arizona_enable_reset(struct arizona *arizona)
>  static void arizona_disable_reset(struct arizona *arizona)
>  {
>  	if (arizona->pdata.reset) {
> +		switch (arizona->type) {
> +		case WM5110:
> +		case WM8280:
> +			/* Meet requirements for minimum reset duration */
> +			msleep(5);
> +			break;
> +		default:
> +			break;
> +		}
> +
>  		gpio_set_value_cansleep(arizona->pdata.reset, 1);
>  		msleep(1);
>  	}

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/