Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752668AbbD3OuT (ORCPT ); Thu, 30 Apr 2015 10:50:19 -0400 Received: from mga11.intel.com ([192.55.52.93]:22116 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751798AbbD3OuN (ORCPT ); Thu, 30 Apr 2015 10:50:13 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.11,677,1422950400"; d="scan'208";a="718483121" From: guangrong.xiao@linux.intel.com To: pbonzini@redhat.com Cc: gleb@kernel.org, mtosatti@redhat.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Xiao Guangrong Subject: [PATCH 0/9] KVM: MTRR fixes and some cleanups Date: Thu, 30 Apr 2015 18:24:41 +0800 Message-Id: <1430389490-24602-11-git-send-email-guangrong.xiao@linux.intel.com> X-Mailer: git-send-email 1.9.3 In-Reply-To: <1430389490-24602-1-git-send-email-guangrong.xiao@linux.intel.com> References: <1430389490-24602-1-git-send-email-guangrong.xiao@linux.intel.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2392 Lines: 60 From: Xiao Guangrong This are some MTRR bugs if legacy IOMMU device is used on Intel's CPU: - In current code, whenever guest MTRR registers are changed kvm_mmu_reset_context is called to switch to the new root shadow page table, however, it's useless since: 1) the cache type is not cached into shadow page's attribute so that the original root shadow page will be reused 2) the cache type is set on the last spte, that means we should sync the last sptes when MTRR is changed We can fix it by dropping all the spte in the gfn range which is being updated by MTRR - some bugs are in get_mtrr_type(); 1: bit 2 of mtrr_state->enabled is corresponding bit 11 of IA32_MTRR_DEF_TYPE MSR which completely control MTRR's enablement that means other bits are ignored if it is cleared 2: the fixed MTRR ranges are controlled by bit 1 of mtrr_state->enabled (bit 10 of IA32_MTRR_DEF_TYPE) 3: if MTRR is disabled, UC is applied to all of physical memory rather than mtrr_state->def_type - we need not to reset mmu once cache policy is changed since shadow page table does not virtualize any cache policy Also, these are some cleanups to make current MMU code more cleaner and help us fixing the bug more easier. Xiao Guangrong (9): KVM: MMU: fix decoding cache type from MTRR KVM: MMU: introduce slot_handle_level() and its helper KVM: MMU: use slot_handle_level and its helper to clean up the code KVM: MMU: introduce for_each_rmap_spte() KVM: MMU: KVM: introduce for_each_slot_rmap KVM: MMU: introduce kvm_zap_rmapp KVM: MMU: introduce kvm_zap_gfn_range() KVM: MMU: fix MTRR update KVM: x86: do not reset mmu if CR0.CD and CR0.NW are changed arch/x86/include/asm/kvm_host.h | 2 + arch/x86/kvm/mmu.c | 407 ++++++++++++++++++++++------------------ arch/x86/kvm/mmu.h | 1 + arch/x86/kvm/mmu_audit.c | 4 +- arch/x86/kvm/svm.c | 5 + arch/x86/kvm/vmx.c | 58 ++++++ arch/x86/kvm/x86.c | 5 +- 7 files changed, 294 insertions(+), 188 deletions(-) -- 1.9.3 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/