Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752023AbbD3Kz3 (ORCPT ); Thu, 30 Apr 2015 06:55:29 -0400 Received: from eu-smtp-delivery-143.mimecast.com ([207.82.80.143]:8398 "EHLO eu-smtp-delivery-143.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752001AbbD3KzX convert rfc822-to-8bit (ORCPT ); Thu, 30 Apr 2015 06:55:23 -0400 Message-ID: <55420A18.7080203@arm.com> Date: Thu, 30 Apr 2015 11:55:20 +0100 From: "Suzuki K. Poulose" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: "msalter@redhat.com" CC: Will Deacon , Mark Rutland , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Punit Agrawal , "arm@kernel.org" Subject: Re: [PATCH V2] drivers: CCI: fix used_mask init in validate_group() References: <20150409144029.GE9648@leverpostej> <1428591425-17330-1-git-send-email-msalter@redhat.com> <20150409153629.GI9648@leverpostej> <20150413124121.GF2869@arm.com> In-Reply-To: <20150413124121.GF2869@arm.com> X-OriginalArrivalTime: 30 Apr 2015 10:55:20.0716 (UTC) FILETIME=[26DADCC0:01D08334] X-MC-Unique: EqGSQcIsRmOZYsgN5gccZw-1 Content-Type: text/plain; charset=WINDOWS-1252; format=flowed Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1333 Lines: 34 On 13/04/15 13:41, Will Deacon wrote: > On Thu, Apr 09, 2015 at 04:36:29PM +0100, Mark Rutland wrote: >> On Thu, Apr 09, 2015 at 03:57:05PM +0100, Mark Salter wrote: >>> Currently in validate_group(), there is a static initializer >>> for fake_pmu.used_mask which is based on CPU_BITS_NONE but >>> the used_mask array size is based on CCI_PMU_MAX_HW_EVENTS. >>> CCI_PMU_MAX_HW_EVENTS is not based on NR_CPUS, so CPU_BITS_NONE >>> is not correct and will cause a build failure if NR_CPUS >>> is set high enough to make CPU_BITS_NONE larger than used_mask. >>> >>> Signed-off-by: Mark Salter >> >> Reviewed-by: Mark Rutland >> >> Arnd, Olof, are you happy to take this via arm-soc? >> >> My (broken) patch went via Will's tree because of a perf dependency, but >> other CCI patches have gone via you guys. > > Yeah, arm-soc is the best place for this. You should resend to > arm@kernel.org as a new patch with the relevant acks. Mark Could you please send this to arm-soc as suggested by Will, with the relevant acks/reviews ? Thanks Suzuki -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/