Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751697AbbD3LGz (ORCPT ); Thu, 30 Apr 2015 07:06:55 -0400 Received: from mail-la0-f47.google.com ([209.85.215.47]:35668 "EHLO mail-la0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750795AbbD3LGx (ORCPT ); Thu, 30 Apr 2015 07:06:53 -0400 MIME-Version: 1.0 Date: Thu, 30 Apr 2015 14:06:51 +0300 Message-ID: Subject: Re: [PATCH 1/1 linux-next] exofs: convert simple_str to kstr From: Alexey Dobriyan To: fabf@skynet.be, ooo@electrozaur.com Cc: Linux Kernel Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 909 Lines: 27 > case Opt_pid: > + { > + int rc; > + > if (0 == match_strlcpy(str, &args[0], sizeof(str))) > return -EINVAL; > - opts->pid = simple_strtoull(str, NULL, 0); > + rc = kstrtoull(str, 0, &opts->pid); > + if (rc) > + return rc; kstrto*() functions were designed for proc/sysfs/sysctl/debugfs/... files accepting 1 value from shell: echo 42 >/proc/foo To keep this simplest usecase simple kstrto*() functions accept one optional newline character before mandatory NUL. But in mount option parsing newlines aren't supposed to be. I'll resend parse_integer() shortly which is better suited for such code http://marc.info/?l=linux-kernel&m=142876674416451&w=4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/