Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751950AbbD3Mfe (ORCPT ); Thu, 30 Apr 2015 08:35:34 -0400 Received: from ns.iliad.fr ([212.27.33.1]:51441 "EHLO ns.iliad.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751255AbbD3Mfc (ORCPT ); Thu, 30 Apr 2015 08:35:32 -0400 Message-ID: <55422193.9010905@freebox.fr> Date: Thu, 30 Apr 2015 14:35:31 +0200 From: Nicolas Schichan User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Daniel Borkmann CC: Will Drewry , Kees Cook , linux-kernel@vger.kernel.org, Andy Lutomirski , Mircea Gherzan , Russell King , "David S. Miller" , linux-arm-kernel@lists.infradead.org, ast@plumgrid.com Subject: Re: [PATCH 0/4] Seccomp filter JIT support on ARM. References: <1430314657-2552-1-git-send-email-nschichan@freebox.fr> <554108CC.6000801@iogearbox.net> In-Reply-To: <554108CC.6000801@iogearbox.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1072 Lines: 31 On 04/29/2015 06:37 PM, Daniel Borkmann wrote: > On 04/29/2015 03:37 PM, Nicolas Schichan wrote: > ... >> The fourth and final patch fixes a bug in the emit_udiv() function >> when used to convert a BPF_ALU | BPF_DIV | BPF_K instruction in the >> ARM BPF JIT code. > > Shouldn't that fix go separately, so it can be included into 4.1 > resp. -stable? Sure, shall I resend that separately from the v2 of the serie or is it fine in its current form ? > Would be good if you also Cc Mircea, who wrote the code. Was that > caught by lib/test_bpf.c suite (if not, would be good to add a test > case for it) ? It was detected by an internal test suite we have here. I see that there are some BPF_ALU | BPF_DIV | BPF_K instructions so it might also be caught by lib/test_bpf.c as well. Regards, -- Nicolas Schichan Freebox SAS -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/