Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751252AbbD3NMB (ORCPT ); Thu, 30 Apr 2015 09:12:01 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:41950 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750801AbbD3NL6 (ORCPT ); Thu, 30 Apr 2015 09:11:58 -0400 Date: Thu, 30 Apr 2015 15:11:20 +0200 From: Greg Kroah-Hartman To: James Bottomley Cc: linux-efi@vger.kernel.org, "Kweh, Hock Leong" , LKML , Andy Lutomirski , Peter Jones Subject: Re: [RFC 2/3] firmware_class: split out transaction helpers Message-ID: <20150430131120.GB17936@kroah.com> References: <1430348859.2189.37.camel@HansenPartnership.com> <1430349052.2189.41.camel@HansenPartnership.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1430349052.2189.41.camel@HansenPartnership.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1319 Lines: 30 On Wed, Apr 29, 2015 at 04:10:52PM -0700, James Bottomley wrote: > From: James Bottomley > > The firmware class contains code to manage an arbitrary sized buffer for > discrete read and write operations. We need precisely this ability to update > firmware capsule files (and likely for other transactions as well), so split > out the capability into a library helper > > Signed-off-by: James Bottomley > --- > drivers/base/firmware_class.c | 117 ++++--------------------------- > include/linux/transaction_helper.h | 26 +++++++ > lib/Makefile | 2 +- > lib/transaction_helper.c | 137 +++++++++++++++++++++++++++++++++++++ > 4 files changed, 179 insertions(+), 103 deletions(-) > create mode 100644 include/linux/transaction_helper.h > create mode 100644 lib/transaction_helper.c Interesting, do you think there are other places that can use this "transaction_helper" library? And a bit more documentation would be nice, but on the whole, no objection from me. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/