Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751115AbbD3PnL (ORCPT ); Thu, 30 Apr 2015 11:43:11 -0400 Received: from mail-pa0-f51.google.com ([209.85.220.51]:35368 "EHLO mail-pa0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750823AbbD3PnH (ORCPT ); Thu, 30 Apr 2015 11:43:07 -0400 From: Kevin Hilman To: Kukjin Kim Cc: "'Javier Martinez Canillas'" , "'Doug Anderson'" , "'Olof Johansson'" , "'Krzysztof Kozlowski'" , "'Andrzej Hajda'" , "'Tyler Baker'" , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] ARM: dts: Make DP a consumer of DISP1 power domain on Exynos5420 References: <1428870659-5525-1-git-send-email-javier.martinez@collabora.co.uk> <552F6750.6020306@collabora.co.uk> <55417810.6070202@collabora.co.uk> <126501d082dd$af818a30$0e849e90$@kernel.org> Date: Thu, 30 Apr 2015 08:43:03 -0700 In-Reply-To: <126501d082dd$af818a30$0e849e90$@kernel.org> (Kukjin Kim's message of "Thu, 30 Apr 2015 09:36:23 +0900") Message-ID: <7hegn1pqpk.fsf@deeprootsystems.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2229 Lines: 61 Kukjin Kim writes: > Javier Martinez Canillas wrote: >> >> Hello Kukjin, >> > Hi, > >> On 04/16/2015 09:40 AM, Javier Martinez Canillas wrote: >> > >> > On 04/12/2015 10:30 PM, Javier Martinez Canillas wrote: >> >> Commit ea08de16eb1b ("ARM: dts: Add DISP1 power domain for exynos5420") >> >> added a device node for the Exynos5420 DISP1 power domain but dit not >> >> make the DP controller a consumer of that power domain. >> >> >> >> This causes an "Unhandled fault: imprecise external abort" error if the >> >> exynos-dp driver tries to access the DP controller registers and the PD >> >> was turned off. This lead to a kernel panic and a complete system hang. >> >> >> >> Make the DP controller device node a consumer of the DISP1 power domain >> >> to ensure that the PD is turned on when the exynos-dp driver is probed. >> >> >> >> Fixes: ea08de16eb1b ("ARM: dts: Add DISP1 power domain for exynos5420") >> >> Signed-off-by: Javier Martinez Canillas >> > >> > Any comments about this patch? >> > >> > It's very trivial but fixes a very important regression on Exynos5420 boards >> > with display panel and Peach Pit and Pi have been broken since next-20150401. >> > >> > This [0] is the Peach Pit boot log with yesteday's linux-next for example. >> > >> > Best regards, >> > Javier >> > >> > [0]: http://arm-soc.lixom.net/bootlogs/next/next-20150415/pit-arm-exynos_defconfig.html >> > >> >> It has been many weeks since this patch has been posted and linux-next >> is still broken: >> >> http://arm-soc.lixom.net/bootlogs/next/next-20150429/pi-arm-exynos_defconfig.html >> >> Could you please apply $subject to fix the imprecise external abort issue. >> > Sure I'll in this weekend. > > Thanks for your gentle reminder ;-) Tested-by: Kevin Hilman I confirm that this patch fixes the imprecise aborts (and sometimes kernel panics) that I'm seeing on exynos5800-peach-pi with linux-next. Kevin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/