Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751947AbbD3P77 (ORCPT ); Thu, 30 Apr 2015 11:59:59 -0400 Received: from e28smtp05.in.ibm.com ([122.248.162.5]:46989 "EHLO e28smtp05.in.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750791AbbD3P75 (ORCPT ); Thu, 30 Apr 2015 11:59:57 -0400 From: "Aneesh Kumar K.V" To: "Kirill A. Shutemov" Cc: akpm@linux-foundation.org, paulus@samba.org, benh@kernel.crashing.org, kirill.shutemov@linux.intel.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 1/3] mm/thp: Use pmdp_splitting_flush_notify to clear pmd on splitting In-Reply-To: <20150430133035.GF15874@node.dhcp.inet.fi> References: <1429823043-157133-1-git-send-email-kirill.shutemov@linux.intel.com> <1430382341-8316-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> <1430382341-8316-2-git-send-email-aneesh.kumar@linux.vnet.ibm.com> <20150430133035.GF15874@node.dhcp.inet.fi> User-Agent: Notmuch/0.19+103~g294bb6d (http://notmuchmail.org) Emacs/24.4.1 (x86_64-pc-linux-gnu) Date: Thu, 30 Apr 2015 21:29:48 +0530 Message-ID: <87iocd38uj.fsf@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15043015-0017-0000-0000-000004DB4B13 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1041 Lines: 32 "Kirill A. Shutemov" writes: >> @@ -184,3 +185,13 @@ void pmdp_invalidate(struct vm_area_struct *vma, unsigned long address, >> } >> #endif /* CONFIG_TRANSPARENT_HUGEPAGE */ >> #endif >> + >> +#ifndef __HAVE_ARCH_PMDP_SPLITTING_FLUSH_NOTIFY >> +#ifdef CONFIG_TRANSPARENT_HUGEPAGE >> +void pmdp_splitting_flush_notify(struct vm_area_struct *vma, >> + unsigned long address, pmd_t *pmdp) >> +{ >> + pmdp_clear_flush_notify(vma, address, pmdp); >> +} >> +#endif /* CONFIG_TRANSPARENT_HUGEPAGE */ >> +#endif > > I think it worth inlining. Let's put it to > > It probably worth combining with collapse counterpart in the same patch. > I tried that first, But that pulls in mmu_notifier.h and huge_mm.h headers and other build failures -aneesh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/