Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752285AbbD3RB4 (ORCPT ); Thu, 30 Apr 2015 13:01:56 -0400 Received: from exprod5og118.obsmtp.com ([64.18.0.160]:46083 "EHLO mail-lb0-f182.google.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751489AbbD3RBq (ORCPT ); Thu, 30 Apr 2015 13:01:46 -0400 From: Semen Protsenko To: Linus Walleij , Alexandre Courbot Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Grygorii Strashko Subject: [RESEND PATCH 2/3] gpio: max732x: Add IRQF_SHARED to irq flags Date: Thu, 30 Apr 2015 20:00:37 +0300 Message-Id: <1430413238-9916-2-git-send-email-semen.protsenko@globallogic.com> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1430413238-9916-1-git-send-email-semen.protsenko@globallogic.com> References: <1430413238-9916-1-git-send-email-semen.protsenko@globallogic.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1339 Lines: 37 It's possible that multiple MAX732X can be hooked up to the same interrupt line with the processor. So add IRQF_SHARED in requesting irq. Signed-off-by: Semen Protsenko --- drivers/gpio/gpio-max732x.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/gpio/gpio-max732x.c b/drivers/gpio/gpio-max732x.c index 7b6fb68..fafc81b 100644 --- a/drivers/gpio/gpio-max732x.c +++ b/drivers/gpio/gpio-max732x.c @@ -507,12 +507,10 @@ static int max732x_irq_setup(struct max732x_chip *chip, chip->irq_features = has_irq; mutex_init(&chip->irq_lock); - ret = devm_request_threaded_irq(&client->dev, - client->irq, - NULL, - max732x_irq_handler, - IRQF_TRIGGER_FALLING | IRQF_ONESHOT, - dev_name(&client->dev), chip); + ret = devm_request_threaded_irq(&client->dev, client->irq, + NULL, max732x_irq_handler, IRQF_ONESHOT | + IRQF_TRIGGER_FALLING | IRQF_SHARED, + dev_name(&client->dev), chip); if (ret) { dev_err(&client->dev, "failed to request irq %d\n", client->irq); -- 1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/