Date: Thu, 30 Apr 2015 13:28:40 -0400
From: Steven Rostedt <rostedt@goodmis.org>
To: Mike Galbraith <umgwanakikbuti@gmail.com>
Cc: Ronny Meeus <ronny.meeus@gmail.com>, linux-kernel@vger.kernel.org,
        Thomas Gleixner <tglx@linutronix.de>
Subject: Re: Issue in PI boosting code in __sched_setscheduler
Message-ID: <20150430132840.6d550b64@gandalf.local.home>
In-Reply-To: <1430413502.3180.157.camel@gmail.com>
References: <CAMJ=MEcz7P+H-rQuABHD5nw8fqN3_vapAJay4mf5cNBMeq6=yQ@mail.gmail.com>
	<1430413502.3180.157.camel@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 4119
Lines: 99

On Thu, 30 Apr 2015 19:05:02 +0200
Mike Galbraith <umgwanakikbuti@gmail.com> wrote:

> LKML is a very high volume list, if you're seeing problems that were
> introduced by a particular patch, it's a good idea to CC the author of
> that patch.
> 
> /me adds CC, and tags (again) to take a peek.

Thanks Mike, although I'm not the author of the patch ;-)  See the
"From:" tag at the beginning of the patch.

> 
> On Tue, 2015-03-17 at 21:10 +0100, Ronny Meeus wrote:
> > I'm using a patched kernel I get from Monta-Vista, it is based on the
> > 3.10 kernel with some RT patches.
> > We ported an application from pSOS RTOS to Linux using the
> > Xenomai-Mercury (=library to map pSOS task to POSIX threads).
> > 
> > One of the patches applied to our kernel is:
> > "[PATCH RT 3/4] sched: Consider pi boosting in setscheduler" (see
> > https://lkml.org/lkml/2012/12/22/77).
> > I see that the code is today also present in the mainline kernel (for
> > example in 3.19).
> > 
> > We have several threads running in the real-time priority domain.
> > ThreadA: running at prio -33.
> > ThreadB: running at prio -35.
> > 
> > ThreadA obtains a PI protected mutex and continues to execute code in
> > the critical section.
> > ThreadB tries to obtain the same mutex and this makes the kernel boost
> > the priority of ThreadA to -35.
> > 
> > While holding the lock, ThreadA changes its priority to -99 to
> > implement a critical section (Xenomai internals). After a short
> > period, the latter critical section is left and the call to lower the
> > priority to its original one (-33) is issued to the kernel.
> > 
> > I would expect that at this moment the priority is lowered to -35
> > since this is the priority of the thread waiting on the mutex (TheadB)
> > but instead the priority is not changed and stays at -99. (Because of
> > the patch mentioned before. The relevant part of the code is also
> > copied below).
> > Since the critical section takes rather long, we start to miss
> > important events processed by higher priority threads.
> > 
> > If I disable the code introduced by the patch, the events are not missed.
> > 
> > My question about this behavior: According to me it is not correct to
> > keep the thread at the higher priority and "assume" that the critical
> > section will not take long anymore.
> > In my opinion the only correct solution is to lower the priority of
> > the calling thread to the highest prio of "the new-priority (-33)" and
> > "the priority of the tasks waiting on the mutex (-35)".

I agree, the proper solution is to change it back to -35. And we have a
way to do that too. I think I can come up with a solution.

-- Steve


> > 
> > Thanks.
> > 
> > Best regards,
> > Ronny
> > 
> > 
> > 3408 static int __sched_setscheduler(struct task_struct *p,
> > 3409                                 const struct sched_attr *attr,
> > 3410                                 bool user)
> > 
> > 3596         /*
> > 3597          * Special case for priority boosted tasks.
> > 3598          *
> > 3599          * If the new priority is lower or equal (user space view)
> > 3600          * than the current (boosted) priority, we just store the new
> > 3601          * normal parameters and do not touch the scheduler class and
> > 3602          * the runqueue. This will be done when the task deboost
> > 3603          * itself.
> > 3604          */
> > 3605         if (rt_mutex_check_prio(p, newprio)) {
> > 3606                 __setscheduler_params(p, attr);
> > 3607                 task_rq_unlock(rq, p, &flags);
> > 3608                 return 0;
> > 3609         }
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> > Please read the FAQ at  http://www.tux.org/lkml/
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/