Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751661AbbD3Skc (ORCPT ); Thu, 30 Apr 2015 14:40:32 -0400 Received: from mail-wg0-f53.google.com ([74.125.82.53]:33328 "EHLO mail-wg0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751077AbbD3Sk3 (ORCPT ); Thu, 30 Apr 2015 14:40:29 -0400 MIME-Version: 1.0 In-Reply-To: <20150430143226.061202df@gandalf.local.home> References: <20150430123303.30f5bd12@gandalf.local.home> <20150430180721.GX5029@twins.programming.kicks-ass.net> <20150430143226.061202df@gandalf.local.home> From: Austin Schuh Date: Thu, 30 Apr 2015 11:40:07 -0700 Message-ID: Subject: Re: [PATCH][RT] xfs: Disable preemption when grabbing all icsb counter locks To: Steven Rostedt Cc: Peter Zijlstra , LKML , linux-rt-users , Thomas Gleixner , Sebastian Andrzej Siewior , Clark Williams , Dave Chinner Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 900 Lines: 22 On Thu, Apr 30, 2015 at 11:32 AM, Steven Rostedt wrote: > On Thu, 30 Apr 2015 20:07:21 +0200 > Peter Zijlstra wrote: >> The irony, this is distinctly non deterministic code you're putting >> under a RT specific preempt_disable ;-) > > I know :-( > > Unfortunately, a RT behaving fix would be much more invasive and would > probably require the help of the xfs folks. For now, this just prevents > a live lock that can happen and halt the system, where it becomes > deterministic catastrophe. > > -- Steve Would it work to instead create a lock to replace the preempt_enable_rt/preempt_disable_rt pair in XFS? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/