Date: Thu, 30 Apr 2015 20:42:32 +0200
From: Borislav Petkov <bp@suse.de>
To: "Luis R. Rodriguez" <mcgrof@suse.com>
Cc: Kyle McMartin <kyle@kernel.org>, Christoph Lameter <cl@linux.com>,
        Alok N Kataria <alokk@calsoftinc.com>,
        Shobhit Dayal <shobhit@calsoftinc.com>,
        Shai Fultheim <shai@scalex86.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        "Luis R. Rodriguez" <mcgrof@do-not-panic.com>, mingo@elte.hu,
        tglx@linutronix.de, hpa@zytor.com, plagnioj@jcrosoft.com,
        tomi.valkeinen@ti.com, daniel.vetter@intel.com, airlied@linux.ie,
        dledford@redhat.com, awalls@md.metrocast.net, syrjala@sci.fi,
        luto@amacapital.net, mst@redhat.com, cocci@systeme.lip6.fr,
        linux-kernel@vger.kernel.org, Juergen Gross <jgross@suse.com>,
        Daniel Vetter <daniel.vetter@ffwll.ch>,
        Dave Airlie <airlied@redhat.com>, Bjorn Helgaas <bhelgaas@google.com>,
        x86@kernel.org
Subject: Re: [PATCH v4 2/8] init.h: add __read_mostly to early_param_on_off()
Message-ID: <20150430184232.GG5117@pd.tnic>
References: <1430343867-1001-1-git-send-email-mcgrof@do-not-panic.com>
 <1430343867-1001-3-git-send-email-mcgrof@do-not-panic.com>
 <20150430160044.GF5117@pd.tnic>
 <20150430183200.GW5622@wotan.suse.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20150430183200.GW5622@wotan.suse.de>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 955
Lines: 23

On Thu, Apr 30, 2015 at 08:32:00PM +0200, Luis R. Rodriguez wrote:
> In this particular case early_param_on_off() will be used for boot
> time kernel parameters which we do not intend on dynamically change a
> lot at run time, we

It is not about whether you're going to dynamically change it but more
about how often it is accessed. If it is accessed only a couple of times
tops during boot and then never again during the system lifetime - which
is generally the case for most boot params - then you certainly don't
want to pollute the read.mostly section with dead weight. You can just
as well use a stinking normal variable.

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/