Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752026AbbD3TQp (ORCPT ); Thu, 30 Apr 2015 15:16:45 -0400 Received: from mail-la0-f45.google.com ([209.85.215.45]:35167 "EHLO mail-la0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751085AbbD3TQm (ORCPT ); Thu, 30 Apr 2015 15:16:42 -0400 MIME-Version: 1.0 In-Reply-To: <554277F3.7060500@gmail.com> References: <1430415954-29517-1-git-send-email-sebastian.hesselbarth@gmail.com> <1430415954-29517-4-git-send-email-sebastian.hesselbarth@gmail.com> <20150430183043.GA21890@deathray> <554277F3.7060500@gmail.com> Date: Thu, 30 Apr 2015 16:16:40 -0300 Message-ID: Subject: Re: [PATCH 3/4] clk: si5351: Do not pass struct clk in platform_data From: Fabio Estevam To: Sebastian Hesselbarth Cc: Michael Welling , Jean-Francois Moine , Mike Turquette , Stephen Boyd , linux-kernel , Russell King , linux-clk@vger.kernel.org, "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 744 Lines: 25 Hi Sebastian, On Thu, Apr 30, 2015 at 3:44 PM, Sebastian Hesselbarth wrote: > Fabio, > > Michael is right, the check is for bailing out if none of the parent > clocks is available. + if (IS_ERR(drvdata->pxtal) && IS_ERR(drvdata->pclkin)) { + dev_err(&client->dev, "missing at least one parent clock\n"); + return -EINVAL; + } Then shouldn't the error message be: "missing both parent clocks\n" ? Regards, Fabio Estevam -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/