Message-ID: <1430426026.2187.5.camel@x220>
Subject: Re: [PATCH] iio: acpi: Add ACPI0008 Ambient Light Sensor
From: Paul Bolle <pebolle@tiscali.nl>
To: Gabriele Mazzotta <gabriele.mzt@gmail.com>
Cc: jic23@kernel.org, knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net,
        marxin.liska@gmail.com, marex@denx.de, rui.zhang@intel.com,
        linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org
Date: Thu, 30 Apr 2015 22:33:46 +0200
In-Reply-To: <1430306845-7117-1-git-send-email-gabriele.mzt@gmail.com>
References: <1430306845-7117-1-git-send-email-gabriele.mzt@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1301
Lines: 34

Just a nit: a license mismatch.

On Wed, 2015-04-29 at 13:27 +0200, Gabriele Mazzotta wrote:
> --- /dev/null
> +++ b/drivers/iio/light/acpi-als.c

> + * This program is free software; you can redistribute it and/or modify it
> + * under the terms and conditions of the GNU General Public License,
> + * version 2, as published by the Free Software Foundation.
> + *
> + * This program is distributed in the hope it will be useful, but WITHOUT
> + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
> + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
> + * more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program. If not, see <http://www.gnu.org/licenses/>.

This states the license is GPL v2.

> +MODULE_LICENSE("GPL");

And, according to include/linux/module.h, this states the license is GPL
v2 or later. So I think either the comment at the top of this file or
the ident used in the MODULE_LICENSE() macro should be changed.


Paul Bolle

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/