Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752005AbbD3Uhs (ORCPT ); Thu, 30 Apr 2015 16:37:48 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:59350 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751348AbbD3Uhp (ORCPT ); Thu, 30 Apr 2015 16:37:45 -0400 Date: Thu, 30 Apr 2015 16:37:42 -0400 (EDT) Message-Id: <20150430.163742.1867744843397612112.davem@davemloft.net> To: tcamuso@redhat.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, manish.chopra@qlogic.com, sony.chacko@qlogic.com, rajesh.borundia@qlogic.com, nhorman@redhat.com Subject: Re: [PATCH] netxen_nic: use spin_[un]lock_bh around tx_clean_lock From: David Miller In-Reply-To: <1430394687-78627-1-git-send-email-tcamuso@redhat.com> References: <1430394687-78627-1-git-send-email-tcamuso@redhat.com> X-Mailer: Mew version 6.6 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 30 Apr 2015 13:37:45 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 781 Lines: 19 From: Tony Camuso Date: Thu, 30 Apr 2015 07:51:27 -0400 > While testing this driver with DEBUG_LOCKDEP and DEBUG_SPINLOCK > enabled did not produce any traces, it would be more prudent in the > case of tx_clean_lock to use spin_[un]lock_bh, since this lock is > manipulated in both the process and softirq contexts. > > This patch was tested for functionality and regressions with netperf > and DEBUG_LOCKDEP and DEBUG_SPINLOCK enabled. > > Signed-off-by: Tony Camuso Applied, thanks Tony. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/