Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751737AbbD3Vxt (ORCPT ); Thu, 30 Apr 2015 17:53:49 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:50343 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751300AbbD3Vxr (ORCPT ); Thu, 30 Apr 2015 17:53:47 -0400 Date: Thu, 30 Apr 2015 14:53:46 -0700 From: Andrew Morton To: Mel Gorman Cc: Nathan Zimmer , Dave Hansen , Waiman Long , Scott Norton , Daniel J Blueman , Linux-MM , LKML Subject: Re: [PATCH 06/13] mm: meminit: Inline some helper functions Message-Id: <20150430145346.1069dd3292997611954e5ac0@linux-foundation.org> In-Reply-To: <1430231830-7702-7-git-send-email-mgorman@suse.de> References: <1430231830-7702-1-git-send-email-mgorman@suse.de> <1430231830-7702-7-git-send-email-mgorman@suse.de> X-Mailer: Sylpheed 3.4.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1262 Lines: 37 On Tue, 28 Apr 2015 15:37:03 +0100 Mel Gorman wrote: > early_pfn_in_nid() and meminit_pfn_in_nid() are small functions that are > unnecessarily visible outside memory initialisation. As well as unnecessary > visibility, it's unnecessary function call overhead when initialising pages. > This patch moves the helpers inline. mm/page_alloc.c: In function 'memmap_init_zone': mm/page_alloc.c:4287: error: implicit declaration of function 'early_pfn_in_nid' --- a/mm/page_alloc.c~mm-meminit-inline-some-helper-functions-fix +++ a/mm/page_alloc.c @@ -950,8 +950,16 @@ static inline bool __meminit early_pfn_i { return meminit_pfn_in_nid(pfn, node, &early_pfnnid_cache); } + +#else + +static inline bool __meminit early_pfn_in_nid(unsigned long pfn, int node) +{ + return true; +} #endif + #ifdef CONFIG_CMA /* Free whole pageblock and set its migration type to MIGRATE_CMA. */ void __init init_cma_reserved_pageblock(struct page *page) allmodconfig. It's odd that nobody else hit this... -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/