Date: Fri, 1 May 2015 06:43:12 +0800
From: Herbert Xu <herbert@gondor.apana.org.au>
To: Tadeusz Struk <tadeusz.struk@intel.com>
Cc: corbet@lwn.net, keescook@chromium.org, qat-linux@intel.com,
        jwboyer@redhat.com, richard@nod.at, d.kasatkin@samsung.com,
        linux-kernel@vger.kernel.org, steved@redhat.com, dhowells@redhat.com,
        vgoyal@redhat.com, james.l.morris@oracle.com, jkosina@suse.cz,
        zohar@linux.vnet.ibm.com, davem@davemloft.net, jdelvare@suse.de,
        linux-crypto@vger.kernel.org
Subject: Re: [PATCH RFC 1/2] crypto: add PKE API
Message-ID: <20150430224312.GA30417@gondor.apana.org.au>
References: <20150430223647.10157.82156.stgit@tstruk-mobl1>
 <20150430223652.10157.86151.stgit@tstruk-mobl1>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150430223652.10157.86151.stgit@tstruk-mobl1>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1145
Lines: 33

On Thu, Apr 30, 2015 at 03:36:52PM -0700, Tadeusz Struk wrote:
>
> +struct pke_alg {
> +	int (*sign)(struct pke_request *pkereq);
> +	int (*verify)(struct pke_request *pkereq);
> +	int (*encrypt)(struct pke_request *pkereq);
> +	int (*decrypt)(struct pke_request *pkereq);
> +
> +	u8 pub_mpis;	/* Number of MPIs in public key */
> +	u8 sec_mpis;	/* Number of MPIs in secret key */
> +	u8 sig_mpis;	/* Number of MPIs in a signature */
> +#define PKEY_CAN_ENCRYPT	0x01
> +#define PKEY_CAN_DECRYPT	0x02
> +#define PKEY_CAN_SIGN		0x04
> +#define PKEY_CAN_VERIFY		0x08
> +	u8 capabilities;
> +};

Please remodel it after pcompress or the newly converted rng type.

This union stuff has been obsolete since 2008 and it's time for
it to die.

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/