Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753185AbbD3Wsr (ORCPT ); Thu, 30 Apr 2015 18:48:47 -0400 Received: from mailapp01.imgtec.com ([195.59.15.196]:7865 "EHLO mailapp01.imgtec.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751408AbbD3Wsp (ORCPT ); Thu, 30 Apr 2015 18:48:45 -0400 Message-ID: <5542B019.7010303@imgtec.com> Date: Thu, 30 Apr 2015 15:43:37 -0700 From: Leonid Yegoshin User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: "Maciej W. Rozycki" , James Hogan CC: , , Ralf Baechle , Subject: Re: [PATCH] MIPS64: R6: R2 emulation bugfix References: <20150428195335.11229.4516.stgit@ubuntu-yegoshin> <5540A1BF.7060408@imgtec.com> In-Reply-To: Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.20.3.79] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1520 Lines: 37 On 04/29/2015 02:49 AM, Maciej W. Rozycki wrote: > On Wed, 29 Apr 2015, James Hogan wrote: > >>> Error recovery pointers for fixups was improperly set as ".word" >>> which is unsuitable for MIPS64. >>> >>> Replaced by __stringify(PTR) >> Every other case of this sort of thing uses STR(PTR) (or __UA_ADDR in >> uaccess.h). Can we stick to STR(PTR) for consistency please? > Or __PA_ADDR in paccess.h. > > I have mixed feelings, the reason for __stringify being absent is the > macro being generic and more recently added than pieces of code that use > STR, e.g. unaligned.c that has been there since forever. And we do use > __stringify in many other cases. > > On the other hand STR is short and sweet, unlike __stringify. > > So how about adding a macro like __STR_PTR that expands to > __stringify(PTR) and converting all the places throughout our port > (including ones currently using __UA_ADDR/__PA_ADDR) to use the new macro? > > Leonid's bug fix will need to go in first of course. > > Maciej As for me, I don't mind which solution is - STR/__stringify or __PA_ADDR. I just would like to have one for future submissions and I assumed that __stringify is it because it a last one so far introduced. So, I put a decision to maintainer. Ralf? - Leonid. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/