Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753086AbbD3WrR (ORCPT ); Thu, 30 Apr 2015 18:47:17 -0400 Received: from skprod3.natinst.com ([130.164.80.24]:40745 "EHLO ni.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751801AbbD3WrO (ORCPT ); Thu, 30 Apr 2015 18:47:14 -0400 Date: Thu, 30 Apr 2015 17:46:35 -0500 From: Ben Shelton To: Paul Bolle Cc: dwmw2@infradead.org, computersforpeace@gmail.com, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, Jeff Westfahl Subject: Re: [PATCH] mtd: Introduce CONFIG_MTD_RESERVE_END Message-ID: <20150430224635.GA18985@bshelton-desktop> References: <1430335682-6174-1-git-send-email-ben.shelton@ni.com> <1430431357.2187.43.camel@x220> MIME-Version: 1.0 In-Reply-To: <1430431357.2187.43.camel@x220> User-Agent: Mutt/1.5.21 (2010-09-15) X-MIMETrack: Itemize by SMTP Server on US-AUS-MGWOut2/AUS/H/NIC(Release 8.5.3FP6|November 21, 2013) at 04/30/2015 05:46:44 PM, Serialize by Router on US-AUS-MGWOut2/AUS/H/NIC(Release 8.5.3FP6|November 21, 2013) at 04/30/2015 05:46:44 PM, Serialize complete at 04/30/2015 05:46:44 PM Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2015-05-01_01:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 913 Lines: 30 Hi Paul, On 05/01, Paul Bolle wrote: > While you're discussing more substantial questions with Brian, I found > some nits. > > On Wed, 2015-04-29 at 14:28 -0500, Ben Shelton wrote: > > --- a/drivers/mtd/Kconfig > > +++ b/drivers/mtd/Kconfig > > > > +config MTD_RESERVE_END > > + int "Reserved space at the end of an all remaining space partition" > > + depends on MTD_CMDLINE_PARTS = "y" > > (The quotes are unneeded.) > > MTD_CMDLINE_PARTS is tristate. Why does it need to be built-in for this > symbol? Good catch -- MTD_RESERVE_END should apply whether MTD_CMDLINE_PARTS is built-in or a module. I'll fix that in the next version of the patch. Thanks, Ben -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/