Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752680AbbD3XN4 (ORCPT ); Thu, 30 Apr 2015 19:13:56 -0400 Received: from mail-out.m-online.net ([212.18.0.10]:37519 "EHLO mail-out.m-online.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751027AbbD3XNz (ORCPT ); Thu, 30 Apr 2015 19:13:55 -0400 X-Auth-Info: cuseWJNMjeqAti/pokAQLat4uGq7+aciQJHnCtfg8jc= From: Marek Vasut To: Michal Suchanek Subject: Re: [PATCH 3/3] MTD: spi-nor: add flag to not use sector erase. Date: Fri, 1 May 2015 01:13:50 +0200 User-Agent: KMail/1.13.7 (Linux/3.13-trunk-amd64; KDE/4.13.1; x86_64; ; ) Cc: David Woodhouse , Brian Norris , zajec5@gmail.com, Alison Chaiken , Ben Hutchings , Geert Uytterhoeven , "Bean Huo \(beanhuo\)" , "grmoore@altera.com" , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org References: <35add8df33b17e2354d9496eba8597d9d8488f30.1430430153.git.hramrach@gmail.com> In-Reply-To: <35add8df33b17e2354d9496eba8597d9d8488f30.1430430153.git.hramrach@gmail.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Message-Id: <201505010113.50293.marex@denx.de> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 992 Lines: 26 On Thursday, April 30, 2015 at 11:13:12 PM, Michal Suchanek wrote: > The sector size of the flash memory is unclear from datasheet or may > possibly vary between chips so add a flag to always use 4k blocks. > > Currently 4k blocks are always used when possible but in the future > somebody might want to do some optimizations with sector erase. > > Signed-off-by: Michal Suchanek I _think_ you might be able to determine the size, no ? One way is to ask the vendor, but you can also try something like: 1) erase the whole SPI NOR 2) overwrite it with zeroes (or ones ? I think it should be all ones after erasing). 3) Erase sector 0 4) Read some 128 KiB back 5) Observe what is the difference. Best regards, Marek Vasut -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/