Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753267AbbEAATL (ORCPT <rfc822;w@1wt.eu>);
	Thu, 30 Apr 2015 20:19:11 -0400
Received: from smtp.codeaurora.org ([198.145.29.96]:51613 "EHLO
	smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751073AbbEAATD (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 30 Apr 2015 20:19:03 -0400
Date: Thu, 30 Apr 2015 17:19:01 -0700
From: Stephen Boyd <sboyd@codeaurora.org>
To: Heiko Stuebner <heiko@sntech.de>
Cc: mturquette@linaro.org, dianders@chromium.org, linux-clk@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        Boris Brezillon <boris.brezillon@free-electrons.com>,
        Alex Elder <elder@linaro.org>,
        Alexandre Belloni <alexandre.belloni@free-electrons.com>,
        Stephen Warren <swarren@wwwdotorg.org>,
        Max Filippov <jcmvbkbc@gmail.com>, kernel@pengutronix.de,
        Zhangfei Gao <zhangfei.gao@linaro.org>,
        Santosh Shilimkar <ssantosh@kernel.org>,
        Chao Xie <chao.xie@marvell.com>, Jason Cooper <jason@lakedaemon.net>,
        Stefan Wahren <stefan.wahren@i2se.com>,
        Andrew Bresticker <abrestic@chromium.org>,
        Robert Jarzmik <robert.jarzmik@free.fr>,
        Georgi Djakov <georgi.djakov@linaro.org>,
        Sylwester Nawrocki <s.nawrocki@samsung.com>,
        Geert Uytterhoeven <geert+renesas@glider.be>,
        Barry Song <baohua@kernel.org>,
        Dinh Nguyen <dinguyen@opensource.altera.com>,
        Viresh Kumar <viresh.linux@gmail.com>,
        Gabriel FERNANDEZ <gabriel.fernandez@st.com>, emilio@elopez.com.ar,
        Peter De Schrijver <pdeschrijver@nvidia.com>,
        Tero Kristo <t-kristo@ti.com>, Ulf Hansson <ulf.hansson@linaro.org>,
        Pawel Moll <pawel.moll@arm.com>,
        Michal Simek <michal.simek@xilinx.com>
Subject: Re: [PATCH v3 0/2] clk: improve handling of orphan clocks
Message-ID: <20150501001901.GC32407@codeaurora.org>
References: <1429735986-18592-1-git-send-email-heiko@sntech.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1429735986-18592-1-git-send-email-heiko@sntech.de>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1935
Lines: 42

On 04/22, Heiko Stuebner wrote:
> Using orphan clocks can introduce strange behaviour as they don't have
> rate information at all and also of course don't track 
> 
> This v2/v3 takes into account suggestions from Stephen Boyd to not try to
> walk the clock tree at runtime but instead keep track of orphan states
> on clock tree changes and making it mandatory for everybody from the
> start as orphaned clocks should not be used at all.
> 
> 
> This fixes an issue on most rk3288 platforms, where some soc-clocks
> are supplied by a 32khz clock from an external i2c-chip which often
> is only probed later in the boot process and maybe even after the
> drivers using these soc-clocks like the tsadc temperature sensor.
> In this case the driver using the clock should of course defer probing
> until the clock is actually usable.
> 
> 
> As this changes the behaviour for orphan clocks, it would of course
> benefit from more testing than on my Rockchip boards. To keep the
> recipent-list reasonable and not spam to much I selected one (the topmost)
> from the get_maintainer output of each drivers/clk entry.
> Hopefully some will provide Tested-by-tags :-)
> 

<grumble> I don't see any Tested-by: tags yet </grumble>. I've
put these two patches on a separate branch "defer-orphans" and
pushed it to clk-next so we can give it some more exposure.

Unfortunately this doesn't solve the orphan problem for non-OF
providers. What if we did the orphan check in __clk_create_clk()
instead and returned an error pointer for orphans? I suspect that
will solve all cases, right?

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/