Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753415AbbEAHQi (ORCPT ); Fri, 1 May 2015 03:16:38 -0400 Received: from mail-wi0-f173.google.com ([209.85.212.173]:33395 "EHLO mail-wi0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750904AbbEAHQh (ORCPT ); Fri, 1 May 2015 03:16:37 -0400 Date: Fri, 1 May 2015 09:16:31 +0200 From: Ingo Molnar To: Wang Nan Cc: ast@plumgrid.com, davem@davemloft.net, acme@kernel.org, mingo@redhat.com, a.p.zijlstra@chello.nl, masami.hiramatsu.pt@hitachi.com, jolsa@kernel.org, lizefan@kernel.org, linux-kernel@vger.kernel.org, pi3orama@163.com, hekuang@huawei.com Subject: Re: [RFC PATCH 00/22] perf tools: introduce 'perf bpf' command to load eBPF programs. Message-ID: <20150501071631.GA19852@gmail.com> References: <1430391165-30267-1-git-send-email-wangnan0@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1430391165-30267-1-git-send-email-wangnan0@huawei.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1290 Lines: 49 * Wang Nan wrote: > This series of patches is an approach to integrate eBPF with perf. Very promising! > After applying these patches, users are allowed to use following > command to load eBPF program compiled by LLVM into kernel: > > $ perf bpf sample_bpf.o Please keep space for a subcommand space as most other perf subcommands do, i.e. make it something like: perf bpf add sample_bpf.o or: perf bpf run sample_bpf.o or: perf bpf load sample_bpf.o So that future subcommands can be added: perf bpf list perf bpf del <...> perf bpf enable <...> perf bpf disable <...> perf bpf help and 'perf bpf' should probably display the help page by default, so if curious perf users stumble into the new subcommand, they get a basic idea about what it's all about. I.e. you should think about the high level subcommand space right now, and pick proper names - because this is going to determine the future usability and the success of the tool to a large degree. Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/