Date: Fri, 1 May 2015 09:21:26 +0200
From: Ingo Molnar <mingo@kernel.org>
To: George Beshers <gbeshers@sgi.com>
Cc: Mike Travis <travis@sgi.com>, linux-kernel@vger.kernel.org,
        Alex Thorlton <athorlton@sgi.com>, Dimitri Sivanich <sivanich@sgi.com>,
        Ingo Molnar <mingo@redhat.com>, Hedi Berriche <hedi@sgi.com>,
        Russ Anderson <rja@sgi.com>
Subject: Re: [PATCH 1/2] UV: NMI: insert per_cpu accessor function on
 uv_hub_nmi.
Message-ID: <20150501072126.GC19852@gmail.com>
References: <20150430132914.28122.11850.sendpatchset@gulag2.americas.sgi.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150430132914.28122.11850.sendpatchset@gulag2.americas.sgi.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 869
Lines: 30


* George Beshers <gbeshers@sgi.com> wrote:

> UV: NMI: insert this_cpu_read accessor function on uv_hub_nmi.
> 
> UV NMI was accidently broken by this patch.

Broken in what way?

>     commit e16321709c8270f9803bbfdb51e5e02235078c7f
>     Author: Christoph Lameter <cl@linux.com>
>     Date:   Sun Aug 17 12:30:41 2014 -0500

That's a rather old patch. Was no upstream kernel tested since ~August 
last year on UV hardware, or is the bug sporadic? The changelog does 
not tell us.

> This patch insert this_cpu_read() on when accessing the PER_CPU 
> uv_cpu_nmi variable.

Why? What problem does it solve?

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/