Message-ID: <1430465409.2187.47.camel@x220>
Subject: Re: [PATCH 1/3] ASoC: Add gtm601 codec driver
From: Paul Bolle <pebolle@tiscali.nl>
To: Marek Belisko <marek@goldelico.com>
Cc: perex@perex.cz, tiwai@suse.de, broonie@kernel.org, hns@goldelico.com,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        alsa-devel@alsa-project.org
Date: Fri, 01 May 2015 09:30:09 +0200
In-Reply-To: <1430429283-27907-2-git-send-email-marek@goldelico.com>
References: <1430429283-27907-1-git-send-email-marek@goldelico.com>
	 <1430429283-27907-2-git-send-email-marek@goldelico.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 949
Lines: 27

Just a nit: a license mismatch.

On Thu, 2015-04-30 at 23:28 +0200, Marek Belisko wrote:
> --- /dev/null
> +++ b/sound/soc/codecs/gtm601.c

> + *  This program is free software; you can redistribute  it and/or modify it
> + *  under  the terms of  the GNU General  Public License as published by the
> + *  Free Software Foundation;  either version 2 of the  License, or (at your
> + *  option) any later version.

This states the license is GPL v2 or later.

> +MODULE_LICENSE("GPL v2");

And, according to include/linux/module.h, this states the license is
(just) GPL v2. So I think either the comment at the top of this file or
the ident used in the MODULE_LICESE() macro should change.


Paul Bolle

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/