Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752671AbbEAIk1 (ORCPT ); Fri, 1 May 2015 04:40:27 -0400 Received: from smtprelay.synopsys.com ([198.182.60.111]:54836 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750786AbbEAIkR convert rfc822-to-8bit (ORCPT ); Fri, 1 May 2015 04:40:17 -0400 From: Vineet Gupta To: Akinobu Mita , "linux-kernel@vger.kernel.org" , "akpm@linux-foundation.org" CC: "linux-arch@vger.kernel.org" Subject: Re: [PATCH 2/5] arc: use for_each_sg() Thread-Topic: [PATCH 2/5] arc: use for_each_sg() Thread-Index: AQHQg9q8if84aU75XkqWNw/UM/Wm5Q== Date: Fri, 1 May 2015 08:40:12 +0000 Message-ID: References: <1430462846-12022-1-git-send-email-akinobu.mita@gmail.com> <1430462846-12022-2-git-send-email-akinobu.mita@gmail.com> Accept-Language: en-US, en-IN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.12.197.3] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2302 Lines: 65 On Friday 01 May 2015 12:17 PM, Akinobu Mita wrote: > Since arc doesn't select ARCH_HAS_SG_CHAIN, it is not necessary to > use for_each_sg() in order to loop over each sg element. But this can > help find problems with drivers that do not properly initialize their > sg tables when CONFIG_DEBUG_SG is enabled. > > Signed-off-by: Akinobu Mita > Cc: Vineet Gupta > Cc: linux-arch@vger.kernel.org Looks fine to me. However it must be noted (perhaps add to change log) that this will lead to different generated code as sg_next() is a function call etc. So this change is strictly not equivalent to what we had before. Acked-by: Vineet Gupta Thx, -Vineet > --- > arch/arc/include/asm/dma-mapping.h | 12 +++++++----- > 1 file changed, 7 insertions(+), 5 deletions(-) > > diff --git a/arch/arc/include/asm/dma-mapping.h b/arch/arc/include/asm/dma-mapping.h > index 45b8e0c..f787894 100644 > --- a/arch/arc/include/asm/dma-mapping.h > +++ b/arch/arc/include/asm/dma-mapping.h > @@ -178,22 +178,24 @@ dma_sync_single_range_for_device(struct device *dev, dma_addr_t dma_handle, > } > > static inline void > -dma_sync_sg_for_cpu(struct device *dev, struct scatterlist *sg, int nelems, > +dma_sync_sg_for_cpu(struct device *dev, struct scatterlist *sglist, int nelems, > enum dma_data_direction dir) > { > int i; > + struct scatterlist *sg; > > - for (i = 0; i < nelems; i++, sg++) > + for_each_sg(sglist, sg, nelems, i) > _dma_cache_sync((unsigned int)sg_virt(sg), sg->length, dir); > } > > static inline void > -dma_sync_sg_for_device(struct device *dev, struct scatterlist *sg, int nelems, > - enum dma_data_direction dir) > +dma_sync_sg_for_device(struct device *dev, struct scatterlist *sglist, > + int nelems, enum dma_data_direction dir) > { > int i; > + struct scatterlist *sg; > > - for (i = 0; i < nelems; i++, sg++) > + for_each_sg(sglist, sg, nelems, i) > _dma_cache_sync((unsigned int)sg_virt(sg), sg->length, dir); > } > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/