Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753551AbbEAJa0 (ORCPT ); Fri, 1 May 2015 05:30:26 -0400 Received: from mail-wi0-f174.google.com ([209.85.212.174]:38842 "EHLO mail-wi0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751294AbbEAJaX (ORCPT ); Fri, 1 May 2015 05:30:23 -0400 Message-ID: <554347AA.3070502@gmail.com> Date: Fri, 01 May 2015 11:30:18 +0200 From: Sebastian Hesselbarth User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Jean-Francois Moine CC: Mike Turquette , Stephen Boyd , Michael Welling , Russell King , Jason Cooper , Andrew Lunn , Gregory Clement , devicetree@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/4] clk: si5351: Some fixes References: <1430415954-29517-1-git-send-email-sebastian.hesselbarth@gmail.com> <20150501111406.0aa23c7b@armhf> In-Reply-To: <20150501111406.0aa23c7b@armhf> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1451 Lines: 34 On 01.05.2015 11:14, Jean-Francois Moine wrote: > On Thu, 30 Apr 2015 19:45:50 +0200 > Sebastian Hesselbarth wrote: >> For Si5351 clock driver, Michael Welling and Jean-Francois Moine reported >> issues with recent v4.x kernels due to broken/missing/wrong parent clock >> claming. This patch set now deals with the issues reported. >> >> Patch 1 amends the binding documentation mention clock-names property >> for the "xtal" and "clkin" parent clock inputs of Si5351 variants. >> >> Patch 2 adds the clock-names property for the SolidRun CuBox using Si5351 >> with a fixed oscillator connected to "xtal" input. >> >> Patch 3 reworks the way we claim parent clocks by using devm_clk_get() >> for both DT and platform_data based registration. Also, properly check >> for errors returned by devm_clk_get() and prepare/enable the parent clocks. [...] > > I applied the patches 2 and 3, and the audio and video in the Cubox > work fine again. Thanks. Ok, good. You mentioned that on v3.19-rc1 it still "works" i.e. despite the broken/missing clk_get/clk_prepare_enable? Can you check the stable (v3.19, v4.0) versions and see how far we should backport the fix? Sebastian -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/