Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753578AbbEALgw (ORCPT ); Fri, 1 May 2015 07:36:52 -0400 Received: from mail-wi0-f179.google.com ([209.85.212.179]:36568 "EHLO mail-wi0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751145AbbEALgu (ORCPT ); Fri, 1 May 2015 07:36:50 -0400 MIME-Version: 1.0 In-Reply-To: <20150501110311.GV22845@sirena.org.uk> References: <1430429283-27907-1-git-send-email-marek@goldelico.com> <1430429283-27907-2-git-send-email-marek@goldelico.com> <20150501110311.GV22845@sirena.org.uk> Date: Fri, 1 May 2015 13:36:48 +0200 Message-ID: Subject: Re: [PATCH 1/3] ASoC: Add gtm601 codec driver From: Belisko Marek To: Mark Brown Cc: perex@perex.cz, tiwai@suse.de, "Dr. H. Nikolaus Schaller" , "devicetree@vger.kernel.org" , LKML , alsa-devel@alsa-project.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1410 Lines: 48 Hi Mark, On Fri, May 1, 2015 at 1:03 PM, Mark Brown wrote: > On Thu, Apr 30, 2015 at 11:28:01PM +0200, Marek Belisko wrote: > >> select SND_SOC_WM9705 if SND_SOC_AC97_BUS >> select SND_SOC_WM9712 if SND_SOC_AC97_BUS >> select SND_SOC_WM9713 if SND_SOC_AC97_BUS >> + select SND_SOC_GTM601 >> help >> +config SND_SOC_GTM601 >> + tristate 'GTM601 UMTS modem audio codec' >> + > > Keep Makefile and Kconfig sorted. Ok. > >> +/* >> + * Note this is a simple chip with no configuration interface, sample rate is >> + * determined automatically by examining the Master clock and Bit clock ratios >> + */ > >> +#define GTM601_RATES (SNDRV_PCM_RATE_8000) > > Does it or doesn't it support multiple sample rates? It support only 8kHz rate. I'll remove define and use SNDRV_PCM_RATE_8000 only in gtm601_dai struct. Thanks and BR. marek -- as simple and primitive as possible ------------------------------------------------- Marek Belisko - OPEN-NANDRA Freelance Developer Ruska Nova Ves 219 | Presov, 08005 Slovak Republic Tel: +421 915 052 184 skype: marekwhite twitter: #opennandra web: http://open-nandra.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/