Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753656AbbEALjn (ORCPT ); Fri, 1 May 2015 07:39:43 -0400 Received: from mail-wg0-f54.google.com ([74.125.82.54]:36592 "EHLO mail-wg0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751193AbbEALjk (ORCPT ); Fri, 1 May 2015 07:39:40 -0400 MIME-Version: 1.0 In-Reply-To: <1430465409.2187.47.camel@x220> References: <1430429283-27907-1-git-send-email-marek@goldelico.com> <1430429283-27907-2-git-send-email-marek@goldelico.com> <1430465409.2187.47.camel@x220> Date: Fri, 1 May 2015 13:39:39 +0200 Message-ID: Subject: Re: [PATCH 1/3] ASoC: Add gtm601 codec driver From: Belisko Marek To: Paul Bolle Cc: perex@perex.cz, tiwai@suse.de, Mark Brown , "Dr. H. Nikolaus Schaller" , "devicetree@vger.kernel.org" , LKML , alsa-devel@alsa-project.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1483 Lines: 48 Hi Paul, On Fri, May 1, 2015 at 9:30 AM, Paul Bolle wrote: > Just a nit: a license mismatch. Right, I copy and paste license header from wm827 driver but add MODULE_LICENSE wrong version. I'll update in next version. Thanks. > > On Thu, 2015-04-30 at 23:28 +0200, Marek Belisko wrote: >> --- /dev/null >> +++ b/sound/soc/codecs/gtm601.c > >> + * This program is free software; you can redistribute it and/or modify it >> + * under the terms of the GNU General Public License as published by the >> + * Free Software Foundation; either version 2 of the License, or (at your >> + * option) any later version. > > This states the license is GPL v2 or later. > >> +MODULE_LICENSE("GPL v2"); > > And, according to include/linux/module.h, this states the license is > (just) GPL v2. So I think either the comment at the top of this file or > the ident used in the MODULE_LICESE() macro should change. > > > Paul Bolle > BR, marek -- as simple and primitive as possible ------------------------------------------------- Marek Belisko - OPEN-NANDRA Freelance Developer Ruska Nova Ves 219 | Presov, 08005 Slovak Republic Tel: +421 915 052 184 skype: marekwhite twitter: #opennandra web: http://open-nandra.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/